Fix ESlint errors with data science (#15024)

* Fix ESlint errors with data science

* Fix prettier errors

Author: Kartik Raj

src/client/tensorBoard/tensorBoardCodeActionProvider.ts

@@ -2,16 +2,7 @@
 // Licensed under the MIT License.
 
 import { inject, injectable } from 'inversify';
-import {
-    CancellationToken,
-    CodeAction,
-    CodeActionContext,
-    CodeActionKind,
-    CodeActionProvider,
-    languages,
-    Selection,
-    TextDocument
-} from 'vscode';
+import { CodeAction, CodeActionKind, CodeActionProvider, languages, Selection, TextDocument } from 'vscode';
 import { IExtensionSingleActivationService } from '../activation/types';
 import { Commands, PYTHON } from '../common/constants';
 import { NativeTensorBoard, NativeTensorBoardEntrypoints } from '../common/experiments/groups';
@@ -32,12 +23,7 @@ export class TensorBoardCodeActionProvider implements CodeActionProvider, IExten
     }
 
     // eslint-disable-next-line class-methods-use-this
-    public provideCodeActions(
-        document: TextDocument,
-        range: Selection,
-        _context: CodeActionContext,
-        _token: CancellationToken
-    ): CodeAction[] {
+    public provideCodeActions(document: TextDocument, range: Selection): CodeAction[] {
         const cursorPosition = range.active;
         const { text } = document.lineAt(cursorPosition);
         if (containsTensorBoardImport([text])) {

src/client/tensorBoard/tensorBoardCodeLensProvider.ts

@@ -2,7 +2,7 @@
 // Licensed under the MIT License.
 
 import { inject, injectable } from 'inversify';
-import { CancellationToken, CodeLens, Command, languages, Position, Range, TextDocument } from 'vscode';
+import { CodeLens, Command, languages, Position, Range, TextDocument } from 'vscode';
 import { IExtensionSingleActivationService } from '../activation/types';
 import { Commands, PYTHON } from '../common/constants';
 import { NativeTensorBoard, NativeTensorBoardEntrypoints } from '../common/experiments/groups';
@@ -22,7 +22,7 @@ export class TensorBoardCodeLensProvider implements IExtensionSingleActivationSe
     }
 
     // eslint-disable-next-line class-methods-use-this
-    public provideCodeLenses(document: TextDocument, _token: CancellationToken): CodeLens[] {
+    public provideCodeLenses(document: TextDocument): CodeLens[] {
         const command: Command = {
             title: TensorBoard.launchNativeTensorBoardSessionCodeLens(),
             command: Commands.LaunchTensorBoard

src/client/tensorBoard/tensorBoardSession.ts

@@ -91,6 +91,7 @@ export class TensorBoardSession {
         return response === InstallerResponse.Installed;
     }
 
+    // eslint-disable-next-line class-methods-use-this
     private async showFilePicker(): Promise<string | undefined> {
         const selection = await window.showOpenDialog({
             canSelectFiles: false,
@@ -105,6 +106,7 @@ export class TensorBoardSession {
         return undefined;
     }
 
+    // eslint-disable-next-line class-methods-use-this
     private getQuickPickItems(logDir: string | undefined) {
         if (logDir) {
             const useCwd = {

src/test/tensorBoard/tensorBoardCodeActionProvider.unit.test.ts

@@ -4,7 +4,7 @@
 import { assert } from 'chai';
 import { mock } from 'ts-mockito';
 import * as TypeMoq from 'typemoq';
-import { CancellationToken, CodeActionContext, Position, Selection } from 'vscode';
+import { Position, Selection } from 'vscode';
 import { ExperimentService } from '../../client/common/experiments/service';
 import { IExperimentService } from '../../client/common/types';
 import { TensorBoardCodeActionProvider } from '../../client/tensorBoard/tensorBoardCodeActionProvider';
@@ -14,27 +14,18 @@ suite('TensorBoard code action provider', () => {
     let experimentService: IExperimentService;
     let codeActionProvider: TensorBoardCodeActionProvider;
     let selection: TypeMoq.IMock<Selection>;
-    let context: TypeMoq.IMock<CodeActionContext>;
-    let token: TypeMoq.IMock<CancellationToken>;
 
     setup(() => {
         experimentService = mock(ExperimentService);
         codeActionProvider = new TensorBoardCodeActionProvider(experimentService, []);
-        context = TypeMoq.Mock.ofType<CodeActionContext>();
-        token = TypeMoq.Mock.ofType<CancellationToken>();
     });
 
     test('Provides code action for Python files', () => {
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const document = new MockDocument('import foo\nimport tensorboard', 'foo.py', async (_doc) => true);
         selection = TypeMoq.Mock.ofType<Selection>();
         selection.setup((s) => s.active).returns(() => new Position(1, 0));
-        const codeActions = codeActionProvider.provideCodeActions(
-            document,
-            selection.object,
-            context.object,
-            token.object
-        );
+        const codeActions = codeActionProvider.provideCodeActions(document, selection.object);
         assert.ok(
             codeActions.length > 0,
             'Failed to provide code action for Python file containing tensorboard import'
@@ -44,12 +35,7 @@ suite('TensorBoard code action provider', () => {
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const document = new MockDocument('import tensorboard', 'foo.ipynb', async (_doc) => true);
         selection.setup((s) => s.active).returns(() => new Position(0, 0));
-        const codeActions = codeActionProvider.provideCodeActions(
-            document,
-            selection.object,
-            context.object,
-            token.object
-        );
+        const codeActions = codeActionProvider.provideCodeActions(document, selection.object);
         assert.ok(
             codeActions.length > 0,
             'Failed to provide code action for Python ipynb containing tensorboard import'
@@ -59,24 +45,14 @@ suite('TensorBoard code action provider', () => {
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const document = new MockDocument('import foo', 'foo.ipynb', async (_doc) => true);
         selection.setup((s) => s.active).returns(() => new Position(0, 0));
-        const codeActions = codeActionProvider.provideCodeActions(
-            document,
-            selection.object,
-            context.object,
-            token.object
-        );
+        const codeActions = codeActionProvider.provideCodeActions(document, selection.object);
         assert.ok(codeActions.length === 0, 'Provided code action for file without tensorboard import');
     });
     test('Does not provide code action if cursor is not on line containing tensorboard import', () => {
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const document = new MockDocument('import foo\nimport tensorboard', 'foo.py', async (_doc) => true);
         selection.setup((s) => s.active).returns(() => new Position(0, 0));
-        const codeActions = codeActionProvider.provideCodeActions(
-            document,
-            selection.object,
-            context.object,
-            token.object
-        );
+        const codeActions = codeActionProvider.provideCodeActions(document, selection.object);
         assert.ok(
             codeActions.length === 0,
             'Provided code action for file even though cursor was not on line containing import'

src/test/tensorBoard/tensorBoardCodeLensProvider.unit.test.ts

@@ -3,8 +3,6 @@
 
 import { assert } from 'chai';
 import { mock } from 'ts-mockito';
-import * as TypeMoq from 'typemoq';
-import { CancellationToken } from 'vscode';
 import { ExperimentService } from '../../client/common/experiments/service';
 import { IExperimentService } from '../../client/common/types';
 import { TensorBoardCodeLensProvider } from '../../client/tensorBoard/tensorBoardCodeLensProvider';
@@ -13,30 +11,28 @@ import { MockDocument } from '../startPage/mockDocument';
 suite('TensorBoard code lens provider', () => {
     let experimentService: IExperimentService;
     let codeLensProvider: TensorBoardCodeLensProvider;
-    let token: TypeMoq.IMock<CancellationToken>;
 
     setup(() => {
         experimentService = mock(ExperimentService);
         codeLensProvider = new TensorBoardCodeLensProvider(experimentService, []);
-        token = TypeMoq.Mock.ofType<CancellationToken>();
     });
 
     test('Provides code lens for Python files', () => {
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const document = new MockDocument('import tensorboard', 'foo.py', async (_doc) => true);
-        const codeActions = codeLensProvider.provideCodeLenses(document, token.object);
+        const codeActions = codeLensProvider.provideCodeLenses(document);
         assert.ok(codeActions.length > 0, 'Failed to provide code lens for file containing tensorboard import');
     });
     test('Provides code lens for Python ipynbs', () => {
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const document = new MockDocument('import tensorboard', 'foo.ipynb', async (_doc) => true);
-        const codeActions = codeLensProvider.provideCodeLenses(document, token.object);
+        const codeActions = codeLensProvider.provideCodeLenses(document);
         assert.ok(codeActions.length > 0, 'Failed to provide code lens for ipynb containing tensorboard import');
     });
     test('Does not provide code lens if no matching import', () => {
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const document = new MockDocument('import foo', 'foo.ipynb', async (_doc) => true);
-        const codeActions = codeLensProvider.provideCodeLenses(document, token.object);
+        const codeActions = codeLensProvider.provideCodeLenses(document);
         assert.ok(codeActions.length === 0, 'Provided code lens for file without tensorboard import');
     });
 });