Skip to content

Commit 6c9b79c

Browse files
committed
Ensure output panel does not steal focus due to ls errors (#4919)
For #4868 <!-- If an item below does not apply to you, then go ahead and check it off as "done" and strikethrough the text, e.g.: - [x] ~Has unit tests & system/integration tests~ --> - [x] Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR) - [x] Title summarizes what is changing - [x] Has a [news entry](https://github.com/Microsoft/vscode-python/tree/master/news) file (remember to thank yourself!) - [n/a] Has sufficient logging. - [n/a] Has telemetry for enhancements. - [n/a] Unit tests & system/integration tests are added/updated - [n/a] [Test plan](https://github.com/Microsoft/vscode-python/blob/master/.github/test_plan.md) is updated as appropriate - [n/a] [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package-lock.json) has been regenerated by running `npm install` (if dependencies have changed) - [n/a] The wiki is updated with any design decisions/details.
1 parent 434567e commit 6c9b79c

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

news/2 Fixes/4868.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Ensure the `Python` output panel does not steal focus when there errors in the `Language Server`.

src/client/activation/languageServer/analysisOptions.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import { inject, injectable, named } from 'inversify';
77
import * as path from 'path';
88
import { CancellationToken, CompletionContext, ConfigurationChangeEvent, Disposable, Event, EventEmitter, OutputChannel, Position, TextDocument } from 'vscode';
9-
import { LanguageClientOptions, ProvideCompletionItemsSignature } from 'vscode-languageclient';
9+
import { LanguageClientOptions, ProvideCompletionItemsSignature, RevealOutputChannelOn } from 'vscode-languageclient';
1010
import { IWorkspaceService } from '../../common/application/types';
1111
import { isTestExecution, PYTHON_LANGUAGE, STANDARD_OUTPUT_CHANNEL } from '../../common/constants';
1212
import { traceDecorators, traceError } from '../../common/logger';
@@ -117,6 +117,7 @@ export class LanguageServerAnalysisOptions implements ILanguageServerAnalysisOpt
117117
configurationSection: PYTHON_LANGUAGE
118118
},
119119
outputChannel: this.output,
120+
revealOutputChannelOn: RevealOutputChannelOn.Never,
120121
initializationOptions: {
121122
interpreter: {
122123
properties

0 commit comments

Comments
 (0)