Skip to content

Commit 6fcd5d3

Browse files
rchiodokimadeline
andauthored
Rchiodo/rel june update (#12356)
* Update security problems * Update release version * Update 3rd party notices * Add font awesome back to third party notices * ExP telemetry fixes (#12358) * Use extension channel instead of VS Code channel * Use publisher.name extension id (not just name) * Update vscode-tas-client Co-authored-by: Kim-Adeline Miguel <[email protected]>
1 parent a633856 commit 6fcd5d3

File tree

7 files changed

+1701
-3417
lines changed

7 files changed

+1701
-3417
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Changelog
22

3-
## 2020.6.0-rc (15 June 2020)
3+
## 2020.6.0 (15 June 2020)
44

55
### Enhancements
66

ThirdPartyNotices-Distribution.txt

Lines changed: 1527 additions & 3345 deletions
Large diffs are not rendered by default.

ThirdPartyNotices-Repository.txt

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1128,3 +1128,43 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
11281128
END OF enchannel-zmq-backend NOTICES, INFORMATION, AND LICENSE
11291129
=======
11301130

1131+
%% font-awesome NOTICES, INFORMATION, AND LICENSE BEGIN HERE
1132+
=========================================
1133+
Font Name - FontAwesome
1134+
1135+
Font Awesome Free License
1136+
-------------------------
1137+
1138+
Font Awesome Free is free, open source, and GPL friendly. You can use it for
1139+
commercial projects, open source projects, or really almost whatever you want.
1140+
Full Font Awesome Free license: https://fontawesome.com/license/free.
1141+
1142+
# Icons: CC BY 4.0 License (https://creativecommons.org/licenses/by/4.0/)
1143+
In the Font Awesome Free download, the CC BY 4.0 license applies to all icons
1144+
packaged as SVG and JS file types.
1145+
1146+
# Fonts: SIL OFL 1.1 License (https://scripts.sil.org/OFL)
1147+
In the Font Awesome Free download, the SIL OFL license applies to all icons
1148+
packaged as web and desktop font files.
1149+
1150+
# Code: MIT License (https://opensource.org/licenses/MIT)
1151+
In the Font Awesome Free download, the MIT license applies to all non-font and
1152+
non-icon files.
1153+
1154+
# Attribution
1155+
Attribution is required by MIT, SIL OFL, and CC BY licenses. Downloaded Font
1156+
Awesome Free files already contain embedded comments with sufficient
1157+
attribution, so you shouldn't need to do anything additional when using these
1158+
files normally.
1159+
1160+
We've kept attribution comments terse, so we ask that you do not actively work
1161+
to remove them from files, especially code. They're a great way for folks to
1162+
learn about Font Awesome.
1163+
1164+
# Brand Icons
1165+
All brand icons are trademarks of their respective owners. The use of these
1166+
trademarks does not indicate endorsement of the trademark holder by Font
1167+
Awesome, nor vice versa. **Please do not use brand logos for any purpose except
1168+
to represent the company, product, or service to which they refer.**
1169+
=========================================
1170+
END OF font-awesome NOTICES, INFORMATION, AND LICENSE

package-lock.json

Lines changed: 126 additions & 64 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "python",
33
"displayName": "Python",
44
"description": "Linting, Debugging (multi-threaded, remote), Intellisense, Jupyter Notebooks, code formatting, refactoring, unit tests, snippets, and more.",
5-
"version": "2020.6.0-rc",
5+
"version": "2020.6.0",
66
"featureFlags": {
77
"usingNewInterpreterStorage": true
88
},
@@ -91,7 +91,6 @@
9191
"onCommand:python.datascience.selectJupyterInterpreter",
9292
"onCommand:python.datascience.selectjupytercommandline",
9393
"onCommand:python.enableSourceMapSupport",
94-
9594
"onNotebookEditor:jupyter-notebook",
9695
"workspaceContains:**/mspythonconfig.json"
9796
],
@@ -3077,7 +3076,7 @@
30773076
"vscode-languageclient": "^6.2.0-next.2",
30783077
"vscode-languageserver": "^6.2.0-next.2",
30793078
"vscode-languageserver-protocol": "^3.16.0-next.2",
3080-
"vscode-tas-client": "^0.0.757",
3079+
"vscode-tas-client": "^0.0.864",
30813080
"vsls": "^0.3.1291",
30823081
"winreg": "^1.2.4",
30833082
"winston": "^3.2.1",
@@ -3305,7 +3304,7 @@
33053304
"webpack-require-from": "^1.8.0",
33063305
"why-is-node-running": "^2.0.3",
33073306
"wtfnode": "^0.8.0",
3308-
"yargs": "^12.0.2"
3307+
"yargs": "^15.3.1"
33093308
},
33103309
"__metadata": {
33113310
"id": "f1f59ae4-9318-4f3c-a9b5-81b2eaa5f8a5",

src/client/common/experiments/service.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import { getExperimentationService, IExperimentationService, TargetPopulation }
99
import { sendTelemetryEvent } from '../../telemetry';
1010
import { EventName } from '../../telemetry/constants';
1111
import { IApplicationEnvironment } from '../application/types';
12+
import { PVSC_EXTENSION_ID } from '../constants';
1213
import { GLOBAL_MEMENTO, IConfigurationService, IExperimentService, IMemento, IPythonSettings } from '../types';
1314
import { ExperimentationTelemetry } from './telemetry';
1415

@@ -47,7 +48,7 @@ export class ExperimentService implements IExperimentService {
4748

4849
let targetPopulation: TargetPopulation;
4950

50-
if (this.appEnvironment.channel === 'insiders') {
51+
if (this.appEnvironment.extensionChannel === 'insiders') {
5152
targetPopulation = TargetPopulation.Insiders;
5253
} else {
5354
targetPopulation = TargetPopulation.Public;
@@ -56,7 +57,7 @@ export class ExperimentService implements IExperimentService {
5657
const telemetryReporter = new ExperimentationTelemetry();
5758

5859
this.experimentationService = getExperimentationService(
59-
this.appEnvironment.extensionName,
60+
PVSC_EXTENSION_ID,
6061
this.appEnvironment.packageJson.version!,
6162
targetPopulation,
6263
telemetryReporter,

0 commit comments

Comments
 (0)