Update extension to node 16 (#21161)

For #21144

Author: karthiknadig

.github/workflows/build.yml

@@ -9,7 +9,7 @@ on:
       - 'release-*'
 
 env:
-  NODE_VERSION: 14.18.2
+  NODE_VERSION: 16.17.1
   PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
   # Force a path with spaces and to test extension works in these scenarios
   # Unicode characters are causing 2.7 failures so skip that for now.

.github/workflows/pr-check.yml

@@ -8,7 +8,7 @@ on:
       - release*
 
 env:
-  NODE_VERSION: 14.18.2
+  NODE_VERSION: 16.17.1
   PYTHON_VERSION: '3.10' # YML treats 3.10 the number as 3.1, so quotes around 3.10
   MOCHA_REPORTER_JUNIT: true # Use the mocha-multi-reporters and send output to both console (spec) and JUnit (mocha-junit-reporter). Also enables a reporter which exits the process running the tests if it haven't already.
   ARTIFACT_NAME_VSIX: ms-python-insiders-vsix

.nvmrc

@@ -1 +1 @@
-v14.18.2
+v16.17.1

package-lock.json

@@ -1915,7 +1915,7 @@
         "@types/md5": "^2.1.32",
         "@types/mocha": "^9.1.0",
         "@types/nock": "^10.0.3",
-        "@types/node": "^14.18.0",
+        "@types/node": "^16.17.0",
         "@types/semver": "^5.5.0",
         "@types/shortid": "^0.0.29",
         "@types/sinon": "^10.0.11",

package.json

@@ -28,7 +28,8 @@ export class ProcessLogger implements IProcessLogger {
             : fileOrCommand;
         const info = [`> ${this.getDisplayCommands(command)}`];
         if (options?.cwd) {
-            info.push(`cwd: ${this.getDisplayCommands(options.cwd)}`);
+            const cwd: string = typeof options?.cwd === 'string' ? options?.cwd : options?.cwd?.toString();
+            info.push(`cwd: ${this.getDisplayCommands(cwd)}`);
         }
         if (typeof options?.shell === 'string') {
             info.push(`shell: ${identifyShellFromShellPath(options?.shell)}`);

src/client/common/process/logger.ts

@@ -192,7 +192,7 @@ export function execObservable(
     let procExited = false;
     const disposable: IDisposable = {
         dispose() {
-            if (proc && !proc.killed && !procExited) {
+            if (proc && proc.pid && !proc.killed && !procExited) {
                 killPid(proc.pid);
             }
             if (proc) {

src/client/common/process/rawProcessApis.ts

@@ -50,12 +50,14 @@ suite('Module Installer - Poetry', () => {
             switch (command) {
                 case 'poetry env list --full-path':
                     return Promise.resolve<ExecutionResult<string>>({ stdout: '' });
-                case 'poetry env info -p':
-                    if (options.cwd && externalDependencies.arePathsSame(options.cwd, project1)) {
+                case 'poetry env info -p': {
+                    const cwd = typeof options.cwd === 'string' ? options.cwd : options.cwd?.toString();
+                    if (cwd && externalDependencies.arePathsSame(cwd, project1)) {
                         return Promise.resolve<ExecutionResult<string>>({
                             stdout: `${path.join(project1, '.venv')} \n`,
                         });
                     }
+                }
             }
             return Promise.reject(new Error('Command failed'));
         });

src/test/common/installer/poetryInstaller.unit.test.ts

@@ -36,14 +36,18 @@ suite('Process - Process Service', function () {
 
     test('Process is killed', async () => {
         const proc = spawnProc();
-
-        ProcessService.kill(proc.proc.pid);
+        expect(proc.proc.pid !== undefined).to.equal(true, 'invalid pid');
+        if (proc.proc.pid) {
+            ProcessService.kill(proc.proc.pid);
+        }
 
         expect(await proc.exited.promise).to.equal(true, 'process did not die');
     });
     test('Process is alive', async () => {
         const proc = spawnProc();
-
-        expect(ProcessService.isAlive(proc.proc.pid)).to.equal(true, 'process is not alive');
+        expect(proc.proc.pid !== undefined).to.equal(true, 'invalid pid');
+        if (proc.proc.pid) {
+            expect(ProcessService.isAlive(proc.proc.pid)).to.equal(true, 'process is not alive');
+        }
     });
 });

src/test/common/process/proc.unit.test.ts

@@ -54,7 +54,7 @@ export class Proc {
         this.raw = (raw as unknown) as IRawProc;
         this.output = output;
     }
-    public get pid(): number {
+    public get pid(): number | undefined {
         return this.raw.pid;
     }
     public get exited(): boolean {