Switch to using eslint in CI (#15028)

Author: brettcannon

.github/workflows/insiders.yml

@@ -78,15 +78,11 @@ jobs:
       - name: Check dependencies
         run: npm run checkDependencies
 
-      # TODO: Uncomment once we are ready to rely on eslint.
-      # - name: Run linting on TypeScript code
-      #   run: npm run lint
+      - name: Run linting on TypeScript code
+        run: npm run lint
 
-      - name: Run prettier on TypeScript code
-        run: npx prettier 'src/**/*.ts*' --check
-
-      - name: Run prettier on JavaScript code
-        run: npx prettier 'build/**/*.js' --check
+      - name: Run formatting on TypeScript code
+        run: npm run format-check
 
       - name: Use Python ${{env.PYTHON_VERSION}}
         uses: actions/setup-python@v2

.github/workflows/pr-check.yml

@@ -78,15 +78,11 @@ jobs:
       - name: Check dependencies
         run: npm run checkDependencies
 
-      # TODO: Uncomment once we are ready to rely on eslint.
-      # - name: Run linting on TypeScript code
-      #   run: npm run lint
+      - name: Run linting on TypeScript code
+        run: npm run lint
 
-      - name: Run prettier on TypeScript code
-        run: npx prettier 'src/**/*.ts*' --check
-
-      - name: Run prettier on JavaScript code
-        run: npx prettier 'build/**/*.js' --check
+      - name: Run formatting on TypeScript code
+        run: npm run format-check
 
       - name: Use Python ${{env.PYTHON_VERSION}}
         uses: actions/setup-python@v2

.github/workflows/release.yml

@@ -78,9 +78,11 @@ jobs:
       - name: Check dependencies
         run: npm run checkDependencies
 
-      # TODO: Uncomment once we are ready to rely on eslint.
-      # - name: Run linting on TypeScript code
-      #   run: npm run lint
+      - name: Run linting on TypeScript code
+        run: npm run lint
+
+      - name: Run formatting on TypeScript code
+        run: npm run format-check
 
   ### Non-smoke tests
   tests:

package.json

@@ -1977,7 +1977,9 @@
         "testInsiders": "cross-env VSC_PYTHON_CI_TEST_VSC_CHANNEL=insiders INSTALL_PYLANCE_EXTENSION=true TEST_FILES_SUFFIX=insiders.test CODE_TESTS_WORKSPACE=src/testMultiRootWkspc/smokeTests \"node ./out/test/standardTest.js\"",
         "lint-staged": "node gulpfile.js",
         "lint": "eslint --ext .ts,.tsx src",
-        "prettier-fix": "prettier 'src/**/*.ts*' --write && prettier 'build/**/*.js' --write",
+        "lint-fix": "eslint --fix --ext .ts,.tsx src",
+        "format-check": "prettier 'src/**/*.ts*' --check && prettier 'build/**/*.js' --check",
+        "format-fix": "prettier 'src/**/*.ts*' --write && prettier 'build/**/*.js' --write",
         "clean": "gulp clean",
         "addExtensionDependencies": "gulp addExtensionDependencies",
         "updateBuildNumber": "gulp updateBuildNumber",