Remove tslint (#15012)

Author: brettcannon

.eslintignore

@@ -21,9 +21,6 @@ build/webpack/loaders/remarkLoader.js
 build/webpack/loaders/jsonloader.js
 build/webpack/loaders/externalizeDependencies.js
 
-build/tslint-rules/messagesMustBeLocalizedRule.js
-build/tslint-rules/baseRuleWalker.js
-
 src/test/mocks/mementos.ts
 src/test/mocks/process.ts
 src/test/mocks/moduleInstaller.ts

.github/workflows/insiders.yml

@@ -78,8 +78,9 @@ jobs:
       - name: Check dependencies
         run: npm run checkDependencies
 
-      - name: Run linting on TypeScript code
-        run: npx tslint --project tsconfig.json
+      # TODO: Uncomment once we are ready to rely on eslint.
+      # - name: Run linting on TypeScript code
+      #   run: npm run lint
 
       - name: Run prettier on TypeScript code
         run: npx prettier 'src/**/*.ts*' --check

.github/workflows/pr-check.yml

@@ -78,8 +78,9 @@ jobs:
       - name: Check dependencies
         run: npm run checkDependencies
 
-      - name: Run linting on TypeScript code
-        run: npx tslint --project tsconfig.json
+      # TODO: Uncomment once we are ready to rely on eslint.
+      # - name: Run linting on TypeScript code
+      #   run: npm run lint
 
       - name: Run prettier on TypeScript code
         run: npx prettier 'src/**/*.ts*' --check

.github/workflows/release.yml

@@ -78,8 +78,9 @@ jobs:
       - name: Check dependencies
         run: npm run checkDependencies
 
-      - name: Run linting on TypeScript code
-        run: npx tslint --project tsconfig.json
+      # TODO: Uncomment once we are ready to rely on eslint.
+      # - name: Run linting on TypeScript code
+      #   run: npm run lint
 
   ### Non-smoke tests
   tests:

.vscode/extensions.json

@@ -2,7 +2,6 @@
     // See https://go.microsoft.com/fwlink/?LinkId=827846
     // for the documentation about the extensions.json format
     "recommendations": [
-        "ms-vscode.vscode-typescript-tslint-plugin",
         "editorconfig.editorconfig",
         "esbenp.prettier-vscode",
         "dbaeumer.vscode-eslint"

.vscode/settings.json

@@ -31,7 +31,6 @@
         "editor.formatOnSave": true
     },
     "typescript.tsdk": "./node_modules/typescript/lib", // we want to use the TS server from our node_modules folder to control its version
-    "tslint.enable": true,
     "python.linting.enabled": false,
     "python.testing.promptToConfigure": false,
     "python.workspaceSymbols.enabled": false,
@@ -42,8 +41,7 @@
     "prettier.printWidth": 120,
     "prettier.singleQuote": true,
     "editor.codeActionsOnSave": {
-        "source.fixAll.eslint": true,
-        "source.fixAll.tslint": true
+        "source.fixAll.eslint": true
     },
     "python.languageServer": "Pylance",
     "python.analysis.logLevel": "Trace",

.vscode/tasks.json

@@ -12,13 +12,7 @@
             "type": "npm",
             "script": "compile",
             "isBackground": true,
-            "problemMatcher": [
-                "$tsc-watch",
-                {
-                    "base": "$tslint5",
-                    "fileLocation": "relative"
-                }
-            ],
+            "problemMatcher": ["$tsc-watch"],
             "group": {
                 "kind": "build",
                 "isDefault": true
@@ -33,10 +27,7 @@
                 "kind": "build",
                 "isDefault": true
             },
-            "problemMatcher": [
-                "$tsc-watch",
-                "$ts-checker-webpack-watch"
-            ]
+            "problemMatcher": ["$tsc-watch"]
         },
         {
             "label": "Run Unit Tests",

.vscodeignore

@@ -21,7 +21,6 @@ sprint-planning.github-issues
 test.ipynb
 tsconfig*.json
 tsfmt.json
-tslint.json
 vscode-python-signing.*
 
 .github/**

CONTRIBUTING.md

@@ -23,7 +23,7 @@ The following projects have their own repositories:
 1. Windows, macOS, or Linux
 1. [Visual Studio Code](https://code.visualstudio.com/)
 1. The following VS Code extensions:
-    - [TSLint](https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin)
+    - [ESlint](https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint)
     - [Prettier](https://marketplace.visualstudio.com/items?itemName=esbenp.prettier-vscode)
     - [EditorConfig for VS Code](https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig)
 1. Have an issue which has a "needs PR" label (feel free to indicate you would like to provide a PR for the issue so others don't work on it as well)
@@ -49,7 +49,7 @@ If you see warnings that `The engine "vscode" appears to be invalid.`, you can i
 
 ### Incremental Build
 
-Run the `Compile` and `Hygiene` build Tasks from the [Run Build Task...](https://code.visualstudio.com/docs/editor/tasks) command picker (short cut `CTRL+SHIFT+B` or `⇧⌘B`). This will leave build and hygiene tasks running in the background and which will re-run as files are edited and saved. You can see the output from either task in the Terminal panel (use the selector to choose which output to look at).
+Run the `Compile` build task from the [Run Build Task...](https://code.visualstudio.com/docs/editor/tasks) command picker (short cut `CTRL+SHIFT+B` or `⇧⌘B`). This will leave build task running in the background and which will re-run as files are edited and saved. You can see the output from either task in the Terminal panel (use the selector to choose which output to look at).
 
 You can also compile from the command-line. For a full compile you can use: