PORT showStartPage setting fix (#13706) (#13758)

* fix showStartPage setting on configSettings.ts (#13706)

* fix showStartPage setting on configSettings.ts

* add news file

* Fix unit tests

* oops

* update changelog

Author: David Kutugata

CHANGELOG.md

@@ -11,6 +11,8 @@
 
 1. Fixed connection to a Compute Instance from the quickpicks history options.
    ([#13387](https://github.com/Microsoft/vscode-python/issues/13387))
+1. Fixed the behavior of the 'python.showStartPage' setting.
+   ([#13347](https://github.com/microsoft/vscode-python/issues/13347))
 
 ### Thanks
 

src/client/common/configSettings.ts

@@ -544,6 +544,11 @@ export class PythonSettings implements IPythonSettings {
             this.datascience = dataScienceSettings;
         }
 
+        const showStartPage = pythonSettings.get<boolean>('showStartPage');
+        if (showStartPage !== undefined) {
+            this.showStartPage = showStartPage;
+        }
+
         this.insidersChannel = pythonSettings.get<ExtensionChannels>('insidersChannel')!;
     }
 

src/test/common/configSettings/configSettings.unit.test.ts

@@ -47,7 +47,7 @@ suite('Python Settings', async () => {
     let settings: CustomPythonSettings;
     setup(() => {
         sinon.stub(EnvFileTelemetry, 'sendSettingTelemetry').returns();
-        config = TypeMoq.Mock.ofType<WorkspaceConfiguration>(undefined, TypeMoq.MockBehavior.Strict);
+        config = TypeMoq.Mock.ofType<WorkspaceConfiguration>(undefined, TypeMoq.MockBehavior.Loose);
         expected = new CustomPythonSettings(undefined, new MockAutoSelectionService());
         settings = new CustomPythonSettings(undefined, new MockAutoSelectionService());
         expected.defaultInterpreterPath = 'python';