Address Sonar warnings (#14921)

Author: brettcannon

src/client/common/cancellation.ts

@@ -33,8 +33,8 @@ export function createPromiseFromCancellation<T>(options: {
             return;
         }
         const complete = () => {
-            // NOSONAR
-            if (options.token!.isCancellationRequested) {
+            const optionsToken = options.token!; // NOSONAR
+            if (optionsToken.isCancellationRequested) {
                 if (options.cancelAction === 'resolve') {
                     return resolve(options.defaultValue);
                 }

src/client/formatters/yapfFormatter.ts

@@ -25,9 +25,9 @@ export class YapfFormatter extends BaseFormatter {
         const formatSelection = range ? !range.isEmpty : false;
 
         const yapfArgs = ['--diff'];
-        if (formatSelection) {
+        if (formatSelection && range !== undefined) {
             // tslint:disable-next-line:no-non-null-assertion
-            yapfArgs.push(...['--lines', `${range!.start.line + 1}-${range!.end.line + 1}`]);
+            yapfArgs.push(...['--lines', `${range.start.line + 1}-${range.end.line + 1}`]);
         }
         // Yapf starts looking for config file starting from the file path.
         const fallbarFolder = this.getWorkspaceUri(document).fsPath;

src/client/linters/errorHandlers/standard.ts

@@ -13,7 +13,7 @@ export class StandardErrorHandler extends BaseErrorHandler {
     public async handleError(error: Error, resource: Uri, execInfo: ExecutionInfo): Promise<boolean> {
         if (
             typeof error === 'string' &&
-            (error as string).indexOf("OSError: [Errno 2] No such file or directory: '/") > 0
+            (error as string).includes("OSError: [Errno 2] No such file or directory: '/")
         ) {
             return this.nextHandler ? this.nextHandler.handleError(error, resource, execInfo) : Promise.resolve(false);
         }

src/client/pythonEnvironments/discovery/locators/services/condaService.ts

@@ -130,9 +130,7 @@ export class CondaService implements ICondaService {
         if (!this.condaFile) {
             this.condaFile = this.getCondaFileImpl();
         }
-        // tslint:disable-next-line:no-unnecessary-local-variable
-        const condaFile = await this.condaFile!;
-        return condaFile!;
+        return (await this.condaFile)!;
     }
 
     /**

src/client/terminals/codeExecution/terminalCodeExecution.ts

@@ -43,8 +43,8 @@ export class TerminalCodeExecutionProvider implements ICodeExecutionService {
         await this.getTerminalService(resource).sendText(code);
     }
     public async initializeRepl(resource?: Uri) {
-        if (this.replActive && (await this.replActive!)) {
-            await this._terminalService!.show();
+        if (this.replActive && (await this.replActive)) {
+            await this._terminalService.show();
             return;
         }
         this.replActive = new Promise<boolean>(async (resolve) => {

src/client/testing/common/types.ts

@@ -129,8 +129,8 @@ export type TestFile = TestingXMLNode & {
 export type TestSuite = TestingXMLNode & {
     functions: TestFunction[];
     suites: TestSuite[];
-    isUnitTest: Boolean;
-    isInstance: Boolean;
+    isUnitTest: boolean;
+    isInstance: boolean;
 };
 
 export type TestFunction = TestingNode & {