Skip to content

Commit b039f71

Browse files
committed
refinement
1 parent fedd59d commit b039f71

File tree

2 files changed

+2
-27
lines changed

2 files changed

+2
-27
lines changed

src/client/testing/testController/common/utils.ts

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -169,28 +169,6 @@ export function pythonTestAdapterRewriteEnabled(serviceContainer: IServiceContai
169169
return experiment.inExperimentSync(EnableTestAdapterRewrite.experiment);
170170
}
171171

172-
// export async function startTestIdsNamedPipe(testIds: string[]): Promise<string> {
173-
// const pipeName: string = generateRandomPipeName('python-test-ids');
174-
// // uses callback so the on connect action occurs after the pipe is created
175-
// await createNamedPipeServer(pipeName, ([_reader, writer]) => {
176-
// traceVerbose('Test Ids named pipe connected');
177-
// // const num = await
178-
// const msg = {
179-
// jsonrpc: '2.0',
180-
// params: testIds,
181-
// } as Message;
182-
// writer
183-
// .write(msg)
184-
// .then(() => {
185-
// writer.end();
186-
// })
187-
// .catch((ex) => {
188-
// traceError('Failed to write test ids to named pipe', ex);
189-
// });
190-
// });
191-
// return pipeName;
192-
// }
193-
194172
interface ExecutionResultMessage extends Message {
195173
params: ExecutionTestPayload;
196174
}

src/client/testing/testController/pytest/pytestDiscoveryAdapter.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,8 @@ export class PytestTestDiscoveryAdapter implements ITestDiscoveryAdapter {
4545
this.resultResolver?.resolveDiscovery(data);
4646
});
4747

48-
try {
49-
await this.runPytestDiscovery(uri, name, executionFactory, interpreter);
50-
} finally {
51-
traceVerbose('donee');
52-
}
48+
await this.runPytestDiscovery(uri, name, executionFactory, interpreter);
49+
5350
// this is only a placeholder to handle function overloading until rewrite is finished
5451
const discoveryPayload: DiscoveredTestPayload = { cwd: uri.fsPath, status: 'success' };
5552
return discoveryPayload;

0 commit comments

Comments
 (0)