Use nox to install packages (#22381)

Author: karthiknadig

gulpfile.js

@@ -20,7 +20,6 @@ const nativeDependencyChecker = require('node-has-native-dependencies');
 const flat = require('flat');
 const { argv } = require('yargs');
 const os = require('os');
-const rmrf = require('rimraf');
 const typescript = require('typescript');
 
 const tsProject = ts.createProject('./tsconfig.json', { typescript });
@@ -243,100 +242,6 @@ gulp.task('prePublishBundle', gulp.series('webpack', 'renameSourceMaps'));
 gulp.task('checkDependencies', gulp.series('checkNativeDependencies'));
 gulp.task('prePublishNonBundle', gulp.series('compile'));
 
-gulp.task('installPythonRequirements', async () => {
-    let args = [
-        '-m',
-        'pip',
-        '--disable-pip-version-check',
-        'install',
-        '--no-user',
-        '-t',
-        './pythonFiles/lib/python',
-        '--no-cache-dir',
-        '--implementation',
-        'py',
-        '--no-deps',
-        '--upgrade',
-        '-r',
-        './requirements.txt',
-    ];
-    await spawnAsync(process.env.CI_PYTHON_PATH || 'python', args, undefined, true)
-        .then(() => true)
-        .catch((ex) => {
-            console.error("Failed to install requirements using 'python'", ex);
-            return false;
-        });
-
-    args = [
-        '-m',
-        'pip',
-        '--disable-pip-version-check',
-        'install',
-        '--no-user',
-        '-t',
-        './pythonFiles/lib/jedilsp',
-        '--no-cache-dir',
-        '--implementation',
-        'py',
-        '--no-deps',
-        '--upgrade',
-        '-r',
-        './pythonFiles/jedilsp_requirements/requirements.txt',
-    ];
-    await spawnAsync(process.env.CI_PYTHON_PATH || 'python', args, undefined, true)
-        .then(() => true)
-        .catch((ex) => {
-            console.error("Failed to install Jedi LSP requirements using 'python'", ex);
-            return false;
-        });
-});
-
-// See https://github.com/microsoft/vscode-python/issues/7136
-gulp.task('installDebugpy', async () => {
-    // Install dependencies needed for 'install_debugpy.py'
-    const depsArgs = [
-        '-m',
-        'pip',
-        '--disable-pip-version-check',
-        'install',
-        '--no-user',
-        '-t',
-        './pythonFiles/lib/temp',
-        '-r',
-        './build/build-install-requirements.txt',
-    ];
-    await spawnAsync(process.env.CI_PYTHON_PATH || 'python', depsArgs, undefined, true)
-        .then(() => true)
-        .catch((ex) => {
-            console.error("Failed to install dependencies need by 'install_debugpy.py' using 'python'", ex);
-            return false;
-        });
-
-    // Install new DEBUGPY with wheels for python
-    const wheelsArgs = ['./pythonFiles/install_debugpy.py'];
-    const wheelsEnv = { PYTHONPATH: './pythonFiles/lib/temp' };
-    await spawnAsync(process.env.CI_PYTHON_PATH || 'python', wheelsArgs, wheelsEnv, true)
-        .then(() => true)
-        .catch((ex) => {
-            console.error("Failed to install DEBUGPY wheels using 'python'", ex);
-            return false;
-        });
-
-    // Download get-pip.py
-    const getPipArgs = ['./pythonFiles/download_get_pip.py'];
-    const getPipEnv = { PYTHONPATH: './pythonFiles/lib/temp' };
-    await spawnAsync(process.env.CI_PYTHON_PATH || 'python', getPipArgs, getPipEnv, true)
-        .then(() => true)
-        .catch((ex) => {
-            console.error("Failed to download get-pip wheels using 'python'", ex);
-            return false;
-        });
-
-    rmrf.sync('./pythonFiles/lib/temp');
-});
-
-gulp.task('installPythonLibs', gulp.series('installPythonRequirements', 'installDebugpy'));
-
 function spawnAsync(command, args, env, rejectOnStdErr = false) {
     env = env || {};
     env = { ...process.env, ...env };

noxfile.py

@@ -0,0 +1,50 @@
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License.
+
+import pathlib
+import nox
+import shutil
+
+
+@nox.session()
+def install_python_libs(session: nox.Session):
+    requirements = [
+        ("./pythonFiles/lib/python", "./requirements.txt"),
+        (
+            "./pythonFiles/lib/jedilsp",
+            "./pythonFiles/jedilsp_requirements/requirements.txt",
+        ),
+    ]
+    for target, file in requirements:
+        session.install(
+            "-t",
+            target,
+            "--no-cache-dir",
+            "--implementation",
+            "py",
+            "--no-deps",
+            "--require-hashes",
+            "--only-binary",
+            ":all:",
+            "-r",
+            file,
+        )
+
+    session.install("packaging")
+
+    # Install debugger
+    session.run(
+        "python",
+        "./pythonFiles/install_debugpy.py",
+        env={"PYTHONPATH": "./pythonFiles/lib/temp"},
+    )
+
+    # Download get-pip script
+    session.run(
+        "python",
+        "./pythonFiles/download_get_pip.py",
+        env={"PYTHONPATH": "./pythonFiles/lib/temp"},
+    )
+
+    if pathlib.Path("./pythonFiles/lib/temp").exists():
+        shutil.rmtree("./pythonFiles/lib/temp")

package.json

@@ -1646,7 +1646,6 @@
         "nyc": "^15.0.0",
         "prettier": "^2.0.2",
         "rewiremock": "^3.13.0",
-        "rimraf": "^3.0.2",
         "shortid": "^2.2.8",
         "sinon": "^13.0.1",
         "source-map-support": "^0.5.12",

scripts/onCreateCommand.sh

@@ -26,7 +26,8 @@ pyenv exec python3.8 -m venv .venv
 source /workspaces/vscode-python/.venv/bin/activate
 
 # Install required Python libraries.
-npx gulp installPythonLibs
+/workspaces/vscode-python/.venv/bin/python -m pip install nox
+nox --session install_python_libs
 
 /workspaces/vscode-python/.venv/bin/python -m pip install -r build/test-requirements.txt
 /workspaces/vscode-python/.venv/bin/python -m pip install -r build/functional-test-requirements.txt