Skip to content

Commit d0750eb

Browse files
committed
Fix tests
1 parent 90629f0 commit d0750eb

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/test/common/experiments/service.unit.test.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,12 @@ import { Disposable } from 'vscode-jsonrpc';
1111
// sinon can not create a stub if we just point to the exported module
1212
import * as tasClient from 'vscode-tas-client/vscode-tas-client/VSCodeTasClient';
1313
import * as expService from 'vscode-tas-client';
14+
import { TargetPopulation } from 'vscode-tas-client';
1415
import { ApplicationEnvironment } from '../../../client/common/application/applicationEnvironment';
1516
import { IApplicationEnvironment, IWorkspaceService } from '../../../client/common/application/types';
1617
import { WorkspaceService } from '../../../client/common/application/workspace';
1718
import { Channel } from '../../../client/common/constants';
18-
import { ExperimentService, TargetPopulation } from '../../../client/common/experiments/service';
19+
import { ExperimentService } from '../../../client/common/experiments/service';
1920
import { PersistentState } from '../../../client/common/persistentState';
2021
import { IPersistentStateFactory } from '../../../client/common/types';
2122
import { registerLogger } from '../../../client/logging';
@@ -74,13 +75,13 @@ suite('Experimentation service', () => {
7475
}
7576

7677
function configureApplicationEnvironment(channel: Channel, version: string, contributes?: Record<string, unknown>) {
77-
when(appEnvironment.extensionChannel).thenReturn(channel);
78+
when(appEnvironment.channel).thenReturn(channel);
7879
when(appEnvironment.extensionName).thenReturn(PVSC_EXTENSION_ID_FOR_TESTS);
7980
when(appEnvironment.packageJson).thenReturn({ version, contributes });
8081
}
8182

8283
suite('Initialization', () => {
83-
test('Users with a release version of the extension should be in the Public target population', () => {
84+
test('Users with VS Code stable version should be in the Public target population', () => {
8485
const getExperimentationServiceStub = sinon.stub(tasClient, 'getExperimentationService');
8586
configureSettings(true, [], []);
8687
configureApplicationEnvironment('stable', extensionVersion);
@@ -99,7 +100,7 @@ suite('Experimentation service', () => {
99100
);
100101
});
101102

102-
test('Users with an Insiders version of the extension should be the Insiders target population', () => {
103+
test('Users with VS Code Insiders version should be the Insiders target population', () => {
103104
const getExperimentationServiceStub = sinon.stub(tasClient, 'getExperimentationService');
104105

105106
configureSettings(true, [], []);

0 commit comments

Comments
 (0)