Merge branch 'main' into remove-pylance-client2

Author: bschnurr

.github/actions/build-vsix/action.yml

@@ -22,7 +22,7 @@ runs:
   using: 'composite'
   steps:
     - name: Install Node
-      uses: actions/setup-node@v4
+      uses: actions/setup-node@v6
       with:
         node-version: ${{ inputs.node_version }}
         cache: 'npm'
@@ -32,7 +32,7 @@ runs:
 
     # Jedi LS depends on dataclasses which is not in the stdlib in Python 3.7.
     - name: Use Python 3.9 for JediLSP
-      uses: actions/setup-python@v5
+      uses: actions/setup-python@v6
       with:
         python-version: 3.9
         cache: 'pip'
@@ -93,7 +93,7 @@ runs:
         VSIX_NAME: ${{ inputs.vsix_name }}
 
     - name: Upload VSIX
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v5
       with:
         name: ${{ inputs.artifact_name }}
         path: ${{ inputs.vsix_name }}

.github/actions/lint/action.yml

@@ -10,7 +10,7 @@ runs:
   using: 'composite'
   steps:
     - name: Install Node
-      uses: actions/setup-node@v4
+      uses: actions/setup-node@v6
       with:
         node-version: ${{ inputs.node_version }}
         cache: 'npm'
@@ -36,7 +36,7 @@ runs:
       shell: bash
 
     - name: Install Python
-      uses: actions/setup-python@v5
+      uses: actions/setup-python@v6
       with:
         python-version: '3.x'
         cache: 'pip'

.github/instructions/learning.instructions.md

@@ -0,0 +1,34 @@
+---
+applyTo: '**'
+description: This document describes how to deal with learnings that you make. (meta instruction)
+---
+
+This document describes how to deal with learnings that you make.
+It is a meta-instruction file.
+
+Structure of learnings:
+
+-   Each instruction file has a "Learnings" section.
+-   Each learning has a counter that indicates how often that learning was useful (initially 1).
+-   Each learning has a 1 sentence description of the learning that is clear and concise.
+
+Example:
+
+```markdown
+## Learnings
+
+-   Prefer `const` over `let` whenever possible (1)
+-   Avoid `any` type (3)
+```
+
+When the user tells you "learn!", you should:
+
+-   extract a learning from the recent conversation
+    _ identify the problem that you created
+    _ identify why it was a problem
+    _ identify how you were told to fix it/how the user fixed it
+    _ generate only one learning (1 sentence) that helps to summarize the insight gained
+-   then, add the reflected learning to the "Learnings" section of the most appropriate instruction file
+
+Important: Whenever a learning was really useful, increase the counter!!
+When a learning was not useful and just caused more problems, decrease the counter.

.github/instructions/python-quality-checks.instructions.md

@@ -0,0 +1,76 @@
+---
+applyTo: 'python_files/**'
+description: Guide for running and fixing Python quality checks (Ruff and Pyright) that run in CI
+---
+
+# Python Quality Checks — Ruff and Pyright
+
+Run the same Python quality checks that run in CI. All checks target `python_files/` and use config from `python_files/pyproject.toml`.
+
+## Commands
+
+```bash
+npm run check-python              # Run both Ruff and Pyright
+npm run check-python:ruff         # Linting and formatting only
+npm run check-python:pyright      # Type checking only
+```
+
+## Fixing Ruff Errors
+
+**Auto-fix most issues:**
+
+```bash
+cd python_files
+python -m ruff check . --fix
+python -m ruff format
+npm run check-python:ruff  # Verify
+```
+
+**Manual fixes:**
+
+-   Ruff shows file, line number, rule code (e.g., `F841`), and description
+-   Open the file, read the error, fix the code
+-   Common: line length (100 char max), import sorting, unused variables
+
+## Fixing Pyright Errors
+
+**Common patterns and fixes:**
+
+-   **Undefined variable/import**: Add the missing import
+-   **Type mismatch**: Correct the type or add type annotations
+-   **Missing return type**: Add `-> ReturnType` to function signatures
+    ```python
+    def my_function() -> str:  # Add return type
+        return "result"
+    ```
+
+**Verify:**
+
+```bash
+npm run check-python:pyright
+```
+
+## Configuration
+
+-   **Ruff**: Line length 100, Python 3.9+, 40+ rule families (flake8, isort, pyupgrade, etc.)
+-   **Pyright**: Version 1.1.308 (or whatever is found in the environment), ignores `lib/` and 15+ legacy files
+-   Config: `python_files/pyproject.toml` sections `[tool.ruff]` and `[tool.pyright]`
+
+## Troubleshooting
+
+**"Module not found" in Pyright**: Install dependencies
+
+```bash
+python -m pip install --upgrade -r build/test-requirements.txt
+nox --session install_python_libs
+```
+
+**Import order errors**: Auto-fix with `ruff check . --fix`
+
+**Type errors in ignored files**: Legacy files in `pyproject.toml` ignore list—fix if working on them
+
+## Learnings
+
+-   Always run `npm run check-python` before pushing to catch CI failures early (1)
+-   Use `ruff check . --fix` to auto-fix most linting issues before manual review (1)
+-   Pyright version must match CI (1.1.308) to avoid inconsistent results between local and CI runs (1)