2018.11.0-rc (#3490)

Author: brettcannon

.github/release_plan.md

@@ -3,31 +3,31 @@
 - [ ] Update the version in [`package.json`](https://github.com/Microsoft/vscode-python/blob/master/package.json)
 - [ ] Run `npm install` to make sure [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package.json) is up-to-date
 - [ ] Update [`CHANGELOG.md`](https://github.com/Microsoft/vscode-python/blob/master/CHANGELOG.md)
-   - Create a new section for this release
-   - Run [`news`](https://github.com/Microsoft/vscode-python/tree/master/news) (typically `python news | code-insiders -`)
-   - Touch up news entries (and corresponding news entry files)
-   - Copy over the "Thanks" section from the previous release
+   - [ ] Create a new section for this release
+   - [ ] Run [`news`](https://github.com/Microsoft/vscode-python/tree/master/news) (typically `python news | code-insiders -`)
+   - [ ] Touch up news entries (and corresponding news entry files)
+   - [ ] Copy over the "Thanks" section from the previous release
 - [ ] Update [`ThirdPartyNotices-Distribution.txt`](https://github.com/Microsoft/vscode-python/blob/master/ThirdPartyNotices-Distribution.txt)
-   - Run [`tpn`](https://github.com/Microsoft/vscode-python/tree/master/tpn) (typically `python tpn --npm package-lock.json --config tpn/distribution.toml ThirdPartyNotices-Distribution.txt`)
-   - Register any Python changes with [OSPO](https://opensource.microsoft.com/)
+   - [ ] Run [`tpn`](https://github.com/Microsoft/vscode-python/tree/master/tpn) (typically `python tpn --npm package-lock.json --npm-overrides package.datascience-ui.dependencies.json --config tpn/distribution.toml ThirdPartyNotices-Distribution.txt`)
+   - [ ] Register any Python changes with [OSPO](https://opensource.microsoft.com/)
 - [ ] Update [`ThirdPartyNotices-Repository.txt`](https://github.com/Microsoft/vscode-python/blob/master/ThirdPartyNotices-Repository.txt) and register any changes with OSPO
 - [ ] Open appropriate [documentation issues](https://github.com/microsoft/vscode-docs/issues?q=is%3Aissue+is%3Aopen+label%3Apython)
 
 
 # Release candidate (Monday before release)
-
-- [ ] Announce feature freeze
+[Work should be done against the `release` branch]
 - [ ] Ensure all new feature usages are tracked via telemetry
+- [ ] Merge in `master`
 - [ ] Update the version in [`package.json`](https://github.com/Microsoft/vscode-python/blob/master/package.json)
 - [ ] Run `npm install` to make sure [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package.json) is up-to-date
 - [ ] Update [`CHANGELOG.md`](https://github.com/Microsoft/vscode-python/blob/master/CHANGELOG.md)
-   - Update version and date for the release section
-   - Run [`news`](https://github.com/Microsoft/vscode-python/tree/master/news) (typically `python news --final | code-insiders -`)
-   - Touch up news entries (and corresponding news entry files)
-   - Check that the "Thanks" section is up-to-date
+   - [ ] Update version and date for the release section
+   - [ ] Run [`news`](https://github.com/Microsoft/vscode-python/tree/master/news) (typically `python news --final | code-insiders -`)
+   - [ ] Touch up news entries (and corresponding news entry files)
+   - [ ] Check that the "Thanks" section is up-to-date
 - [ ] Update [`ThirdPartyNotices-Distribution.txt`](https://github.com/Microsoft/vscode-python/blob/master/ThirdPartyNotices-Distribution.txt)
-   - Run [`tpn`](https://github.com/Microsoft/vscode-python/tree/master/tpn) (typically `python tpn --npm package-lock.json --config tpn/distribution.toml ThirdPartyNotices-Distribution.txt`)
-   - Register any Python changes with [OSPO](https://opensource.microsoft.com/)
+   - [ ] Run [`tpn`](https://github.com/Microsoft/vscode-python/tree/master/tpn) (typically `python tpn --npm package-lock.json --npm-overrides package.datascience-ui.dependencies.json --config tpn/distribution.toml ThirdPartyNotices-Distribution.txt`)
+   - [ ] Register any Python changes with [OSPO](https://opensource.microsoft.com/)
 - [ ] Update [`ThirdPartyNotices-Repository.txt`](https://github.com/Microsoft/vscode-python/blob/master/ThirdPartyNotices-Repository.txt) and register any changes with OSPO
 - [ ] Merge into the [`release` branch](https://github.com/microsoft/vscode-python/tree/release)
 - [ ] Open appropriate [documentation issues](https://github.com/microsoft/vscode-docs/issues?q=is%3Aissue+is%3Aopen+label%3Apython)
@@ -37,34 +37,34 @@
 # Final (near a VS Code release)
 
 ## Preparation
-[Final PR should be against the `release` branch and then cherrypicked into `master`]
+[Work should be against the `release` branch]
 
-- [ ] Make sure no extraneous files are being included in the `.vsix` file (make sure to check for hidden files)
 - [ ] Make sure the [appropriate pull requests](https://github.com/microsoft/vscode-docs/pulls) for the [documentation](https://code.visualstudio.com/docs/python/python-tutorial) -- including the [WOW](https://code.visualstudio.com/docs/languages/python) page -- are ready
 - [ ] Update the version in [`package.json`](https://github.com/Microsoft/vscode-python/blob/master/package.json)
 - [ ] Run `npm install` to make sure [`package-lock.json`](https://github.com/Microsoft/vscode-python/blob/master/package.json) is up-to-date (the only update should be the version number if `package-lock.json` has been kept up-to-date)
 - [ ] Update [`CHANGELOG.md`](https://github.com/Microsoft/vscode-python/blob/master/CHANGELOG.md)
-   - Update version and date for the release section
-   - Run [`news`](https://github.com/Microsoft/vscode-python/tree/master/news) (typically `python news --final | code-insiders -`)
+   - [ ] Update version and date for the release section
+   - [ ] Run [`news`](https://github.com/Microsoft/vscode-python/tree/master/news) (typically `python news --final | code-insiders -`)
    - Check that the "Thanks" section is up-to-date
 - [ ] Update [`ThirdPartyNotices-Distribution.txt`](https://github.com/Microsoft/vscode-python/blob/master/ThirdPartyNotices-Distribution.txt)
-   - Run [`tpn`](https://github.com/Microsoft/vscode-python/tree/master/tpn) (typically `python tpn --npm package-lock.json --config tpn/distribution.toml ThirdPartyNotices-Distribution.txt`)
-   - Register any Python changes with [OSPO](https://opensource.microsoft.com/)
+   - [ ] Run [`tpn`](https://github.com/Microsoft/vscode-python/tree/master/tpn) (typically `python tpn --npm package-lock.json --npm-overrides package.datascience-ui.dependencies.json --config tpn/distribution.toml ThirdPartyNotices-Distribution.txt`)
+   - [ ] Register any Python changes with [OSPO](https://opensource.microsoft.com/)
 - [ ] Update [`ThirdPartyNotices-Repository.txt`](https://github.com/Microsoft/vscode-python/blob/master/ThirdPartyNotices-Repository.txt) and register any changes with OSPO
 
 ## Release
 
 - [ ] Make sure [CI](https://github.com/Microsoft/vscode-python/blob/master/CONTRIBUTING.md) is passing
 - [ ] Generate the final `.vsix` file
+- [ ] Make sure no extraneous files are being included in the `.vsix` file (make sure to check for hidden files)
 - [ ] Upload the final `.vsix` file to the [marketplace](https://marketplace.visualstudio.com/items?itemName=ms-python.python)
 - [ ] Publish [documentation](https://code.visualstudio.com/docs/python/python-tutorial) [changes](https://github.com/microsoft/vscode-docs/pulls)
 - [ ] Publish the [blog](http://aka.ms/pythonblog) post
 - [ ] Create a [release](https://github.com/Microsoft/vscode-python/releases) on GitHub (which creates an appropriate git tag)
 - [ ] Determine if a hotfix is needed
+- [ ] Merge `release` back into `master`
 
 ## Prep for the _next_ release
 - [ ] Bump the [version](https://github.com/Microsoft/vscode-python/blob/master/package.json) number to the next `alpha`
-- [ ] Lift the feature freeze
 - [ ] Create a new [release plan](https://github.com/Microsoft/vscode-python/edit/master/.github/release_plan.md)
 
 ## Clean up after _this_ release

.github/test_plan.md

@@ -44,7 +44,11 @@
 - Make sure that you do not have `python.pythonPath` specified in your `settings.json` when testing automatic detection
 - Do note that the `Select Interpreter` drop-down window scrolls
 
-- [ ] Detected a single virtual environment at the top-level of the workspace folder (if you created this _after_ opening VS Code, then run `Reload Window` to pick up the new environment)
+- [ ] Detected a single virtual environment at the top-level of the workspace folder on Mac when when `python` command points to default Mac Python installation or `python` command fails in the terminal.
+  - [ ] Appropriate suffix label specified in status bar (e.g. `(venv)`)
+- [ ] Detected a single virtual environment at the top-level of the workspace folder on Windows when `python` fails in the terminal.
+  - [ ] Appropriate suffix label specified in status bar (e.g. `(venv)`)
+- [ ] Detected a single virtual environment at the top-level of the workspace folder
   - [ ] Appropriate suffix label specified in status bar (e.g. `(venv)`)
   - [ ] [`Create Terminal`](https://code.visualstudio.com/docs/python/environments#_activating-an-environment-in-the-terminal) works
     - [ ] Steals focus

.gitignore

@@ -1,4 +1,5 @@
 .DS_Store
+.huskyrc.json
 out
 node_modules
 *.pyc

.travis.yml

@@ -6,9 +6,6 @@ matrix:
         - os: linux
           python: "2.7"
           env: UNIT_TEST=true
-        - os: linux
-          python: "2.7"
-          env: DEBUGGER_TEST=true
         - os: linux
           python: "2.7"
           env: DEBUGGER_TEST_RELEASE=true
@@ -18,9 +15,6 @@ matrix:
         - os: linux
           python: "2.7"
           env: MULTIROOT_WORKSPACE_TEST=true
-        - os: linux
-          python: "3.6-dev"
-          env: DEBUGGER_TEST=true
         - os: linux
           python: "3.6-dev"
           env: DEBUGGER_TEST_RELEASE=true
@@ -33,9 +27,6 @@ matrix:
         - os: linux
           python: "3.6-dev"
           env: PERFORMANCE_TEST=true
-        - os: linux
-          python: "3.7-dev"
-          env: DEBUGGER_TEST=true
         - os: linux
           python: "3.7-dev"
           env: DEBUGGER_TEST_RELEASE=true
@@ -45,6 +36,9 @@ matrix:
         - os: linux
           python: "3.7-dev"
           env: MULTIROOT_WORKSPACE_TEST=true
+        - os: linux
+          python: "3.7-dev"
+          env: BUNDLE=true
 before_install: |
   if [ $TRAVIS_OS_NAME == "linux" ]; then
     export CXX="g++-4.9" CC="gcc-4.9" DISPLAY=:99.0;
@@ -60,39 +54,24 @@ before_install: |
   npm install -g azure-cli
   export CI_PYTHON_PATH=`which python`
 install:
-  - npm ci
+  - travis_wait 5 npm ci
   - npm run clean
-  - npm run vscode:prepublish
+  - npx gulp prePublishNonBundle
   - npx gulp hygiene-modified
+  - python -m pip install --upgrade pip
   - python -m pip install --upgrade -r requirements.txt
-  - python -m pip install -t ./pythonFiles/experimental/ptvsd git+https://github.com/Microsoft/ptvsd/
+  - python -m pip install -t ./pythonFiles/experimental/ptvsd --no-cache-dir --implementation py --no-deps ptvsd
 
 script:
   - if [ $UNIT_TEST == "true" ]; then
         npm run cover:enable;
         npm run test:unittests;
     fi
-  - if [ $TRAVIS_UPLOAD_COVERAGE == "true" ]; then
-        bash <(curl -s https://codecov.io/bash);
-    fi
-  - if [ $DEBUGGER_TEST == "true" ]; then
-        npm run cover:enable;
-        npm run testDebugger --silent;
-    fi
-  - npm run debugger-coverage
-  - if [ $TRAVIS_UPLOAD_COVERAGE == "true" ]; then
-        bash <(curl -s https://codecov.io/bash);
-    fi
-  - npm run clean:ptvsd
-  - pip install -t ./pythonFiles/experimental/ptvsd ptvsd --no-cache-dir;
   - if [ $DEBUGGER_TEST_RELEASE == "true" ]; then
         npm run cover:enable;
         npm run testDebugger --silent;
     fi
   - npm run debugger-coverage
-  - if [ $TRAVIS_UPLOAD_COVERAGE == "true" ]; then
-        bash <(curl -s https://codecov.io/bash);
-    fi
   - if [ $FUNCTIONAL_TEST == "true" ]; then
         python -m pip install --upgrade -r functionalTestRequirements.txt;
         npm run test:functional;
@@ -101,16 +80,10 @@ script:
         npm run cover:enable;
         npm run testSingleWorkspace --silent;
     fi
-  - if [ $TRAVIS_UPLOAD_COVERAGE == "true" ]; then
-        bash <(curl -s https://codecov.io/bash);
-    fi
   - if [ $MULTIROOT_WORKSPACE_TEST == "true" ]; then
         npm run cover:enable;
         npm run testMultiWorkspace --silent;
     fi
-  - if [ $TRAVIS_UPLOAD_COVERAGE == "true" ]; then
-        bash <(curl -s https://codecov.io/bash);
-    fi
   - if [[ "$TRAVIS_BRANCH" == "master" && "$TRAVIS_PULL_REQUEST" == "false" && "$PERFORMANCE_TEST" == "true" ]]; then
         npm run testPerformance --silent;
     fi
@@ -123,6 +96,13 @@ script:
   - if [[ $AZURE_STORAGE_ACCOUNT && "$TRAVIS_BRANCH" == "master" && "$TRAVIS_PULL_REQUEST" == "false" ]]; then
         npm run clean;
         vsce package;
+        azure storage blob upload python*.vsix $AZURE_STORAGE_CONTAINER ms-python-insiders-unbundled.vsix --account-name $AZURE_STORAGE_ACCOUNT --account-key $AZURE_STORAGE_ACCESS_KEY --quiet;
+    fi
+  - if [[ $BUNDLE == "true" && $AZURE_STORAGE_ACCOUNT && "$TRAVIS_BRANCH" == "master" && "$TRAVIS_PULL_REQUEST" == "false" ]]; then
+        npm run clean;
+        npm run package;
+        npx gulp clean:cleanExceptTests;
+        npm run testSmoke;
         azure storage blob upload python*.vsix $AZURE_STORAGE_CONTAINER ms-python-insiders.vsix --account-name $AZURE_STORAGE_ACCOUNT --account-key $AZURE_STORAGE_ACCESS_KEY --quiet;
     fi
   - if [[ $AZURE_STORAGE_ACCOUNT && "$TRAVIS_BRANCH" == release* && "$TRAVIS_PULL_REQUEST" == "false" ]]; then

.vscode/extensions.json

@@ -0,0 +1,7 @@
+{
+    // See https://go.microsoft.com/fwlink/?LinkId=827846
+    // for the documentation about the extensions.json format
+    "recommendations": [
+        "eg2.tslint"
+    ]
+}

.vscode/launch.json

@@ -42,6 +42,7 @@
             "runtimeExecutable": "${execPath}",
             "args": [
                 "${workspaceFolder}/src/testMultiRootWkspc/multi.code-workspace",
+                "--disable-extensions",
                 "--extensionDevelopmentPath=${workspaceFolder}",
                 "--extensionTestsPath=${workspaceFolder}/out/test"
             ],
@@ -63,6 +64,7 @@
             "runtimeExecutable": "${execPath}",
             "args": [
                 "${workspaceFolder}/src/test",
+                "--disable-extensions",
                 "--extensionDevelopmentPath=${workspaceFolder}",
                 "--extensionTestsPath=${workspaceFolder}/out/test"
             ],
@@ -80,6 +82,7 @@
             "runtimeExecutable": "${execPath}",
             "args": [
                 "${workspaceFolder}/src/testMultiRootWkspc/multi.code-workspace",
+                "--disable-extensions",
                 "--extensionDevelopmentPath=${workspaceFolder}",
                 "--extensionTestsPath=${workspaceFolder}/out/test"
             ],
@@ -91,33 +94,14 @@
             ],
             "preLaunchTask": "Compile"
         },
-        {
-            "name": "Tests (Language Server)",
-            "type": "extensionHost",
-            "request": "launch",
-            "runtimeExecutable": "${execPath}",
-            "args": [
-                "${workspaceFolder}/src/test",
-                "--extensionDevelopmentPath=${workspaceFolder}",
-                "--extensionTestsPath=${workspaceFolder}/out/test"
-            ],
-            "stopOnEntry": false,
-            "sourceMaps": true,
-            "outFiles": [
-                "${workspaceFolder}/out/**/*.js"
-            ],
-            "preLaunchTask": "Compile",
-            "env": {
-                "VSC_PYTHON_LANGUAGE_SERVER": "1"
-            }
-        },
         {
             "name": "Tests (VS Code, with code coverage, *.test.ts)",
             "type": "extensionHost",
             "request": "launch",
             "runtimeExecutable": "${execPath}",
             "args": [
                 "${workspaceFolder}/src/test",
+                "--disable-extensions",
                 "--extensionDevelopmentPath=${workspaceFolder}",
                 "--extensionTestsPath=${workspaceFolder}/out/test"
             ],

.vscodeignore

@@ -1,27 +1,34 @@
+!out/client/**/*.map
 **/*.map
+*.vsix
 .appveyor.yml
 .editorconfig
 .eslintrc
 .gitattributes
 .gitignore
 .gitmodules
+.huskyrc.json
 .npmrc
 .travis.yml
 CODE_OF_CONDUCT.md
 CODING_STANDARDS.md
 CONTRIBUTING.md
 CONTRIBUTING - LANGUAGE SERVER.md
 coverconfig.json
+functionalTestRequirements.txt
 gulpfile.js
+package-lock.json
 packageExtension.cmd
+pvsc-dev-ext.py
+PYTHON_INTERACTIVE_TROUBLESHOOTING.md
 tsconfig.json
 tsfmt.json
 tslint.json
 typings.json
 vsc-extension-quickstart.md
 vscode-python-signing.*
 webpack.config.js
-yarn.lock
+webpack.datascience-ui.config.js
 
 .github/**
 .mocha-reporter/**