fixes to linting errors

Author: eleanorjboyd

build/webpack/webpack.extension.browser.config.js

@@ -13,7 +13,7 @@ const packageRoot = path.resolve(__dirname, '..', '..');
 const outDir = path.resolve(packageRoot, 'dist');
 
 /** @type {(env: any, argv: { mode: 'production' | 'development' | 'none' }) => import('webpack').Configuration} */
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
+// eslint-disable-next-line no-unused-vars
 const nodeConfig = (_, { mode }) => ({
     context: packageRoot,
     entry: {

src/client/common/application/applicationEnvironment.ts

@@ -41,6 +41,7 @@ export class ApplicationEnvironment implements IApplicationEnvironment {
                     ? path.join(this.process.env.APPDATA, vscodeFolderName, 'User', 'settings.json')
                     : undefined;
             default:
+                // eslint-disable-next-line getter-return
                 return;
         }
     }

src/client/common/extensions.ts

@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 declare interface String {
     /**
      * Appropriately formats a string so it can be used as an argument for a command in a shell.

src/client/common/terminal/service.ts

@@ -94,6 +94,7 @@ export class TerminalService implements ITerminalService, Disposable {
             this._terminalFirstLaunched = false;
             const promise = new Promise<boolean>((resolve) => {
                 const disposable = this.terminalManager.onDidChangeTerminalShellIntegration(() => {
+                    // eslint-disable-next-line @typescript-eslint/no-use-before-define
                     clearTimeout(timer);
                     disposable.dispose();
                     resolve(true);

src/client/common/utils/cacheUtils.ts

@@ -48,6 +48,7 @@ export class InMemoryCache<T> {
      */
     public get data(): T | undefined {
         if (!this.hasData) {
+            // eslint-disable-next-line getter-return
             return;
         }
         return this.cacheData?.value;

src/client/testing/main.ts

@@ -72,6 +72,7 @@ export class UnitTestManagementService implements IExtensionActivationService {
         this.registerHandlers();
         this.registerCommands();
 
+        // eslint-disable-next-line no-extra-boolean-cast
         if (!!tests.testResults) {
             await this.updateTestUIButtons();
             this.disposableRegistry.push(

src/test/common.ts

@@ -462,6 +462,7 @@ export async function waitForCondition(
         const timeout = setTimeout(() => {
             clearTimeout(timeout);
 
+            // eslint-disable-next-line @typescript-eslint/no-use-before-define
             clearTimeout(timer);
             reject(new Error(errorMessage));
         }, timeoutMs);