Skip to content

Commit f0e234b

Browse files
authored
Point release for Extension with data science changes (#8153)
* Expand variable explorer tests to work for native editor too. (#7699) * Expand variable explorer tests to work for native editor too. * Add comment about async fix for editor open * Review feedback * Allow connection to servers with no token and no password (#7708) * Add capability to support current file path for notebook root (#7724) * Add capability to support current file path for notebook root * Put launch.json back * Use system variables instead of creating separate resolver * Fix mistake in config settings with passing in a uri instead of a string * Make arguments more explicit * Fix IS_WINDOWS to work on unit tests * Better cancellations (#7714) * Variable explorer and mime test fixes for tests (#7740) * Change variable explorer tests to wait for variable explorer complete * Fix native mime test * Review feedback * Try to make 2.7 tests pass * Fix liveshare guest hang issue (#7764) * initial changes * update notebooks on server session change and add test * await correctly * Fix jupyter server startup hang when xeus-cling is installed (#7773) * Make interactive window and native editor take their fontSize and fontFamily from the settings in VS Code. (#7746) * Make interactive window and native editor take their fontSize and fontFamily from the settings in VS Code. We get them in nativeEditor.tsx and in interactivePanel.tsx to apply them as styles, but we also need to send them as props to eventually assign them in the monaco editor. * Moved style from react code to common.css We now get the VS Code styles from the state of the component, instead of computing a style from an element. * Removed getting the font from nativeEditor and interactivePanel, and put it in the mainStateController * Made the interactiveWindow and the nativeEditor react and change their fonts when the user changes them in VS Code, instead of having to reload. * Changed the font props to be an object instead of two separate props to make it easier to maintain. React Context was not used to avoid making the reuse of components more difficult. * Removed some unnecesary passing around of the font prop * removed unnecesary comments * fixed a failing test * Fix a number of perf issues with large notebooks (#7778) * First idea - load cells all at once. Change updates to not update full cell Change global properties to be per cell Change cells to check for updates before rendering * Fix delete to not select at the same time * Make a pending state and a rendered state to use for rendering Some perf fixes for monaco editor. Skip laying out parent etc until necessary * Refactor intellisense to not take so much time on load * More delete and move fixes for intellisense * Fix markdown not switching Fix markdown editor background * Fix some of the time on first render * Add some more unit tests and fix intellisense issue * Add news entry and fix variable explorer open * Remove unnecessary state change * Remove unnecessary merge * Comment change * Postpone widget parent changes * Add new dependency * Update some comments and names to be clearer * Change the default cell marker (#7782) * Change the default cell marker * Fix test failures Fix gather to use new comment Fix formatting on code comments from nls * Fix unit test too * Fix gather to replace #%% * Fix selection and focus not updating when clicking around in a notebook (#7806) * Fix selection and focus not updating when clicking around in a notebook editor. * Also fix add cell to put focus in the new cell * More functional tests for the notebook editor (#7804) * New tests * Add some more functional tests for the notebook editor Make sure when an error occurs on running a cell it's displayed to the user. * Review feedback * Add native command palette cell commands and recontext IW cell commands (#7807) * Tests for keyboard shortcuts in native editor (#7797) * Tests for keyboard shortcuts * Added some more tests * Code review comments * Fix merge issues * Smoke tests does not depend on build stage (#7819) * Smoke tests does not depend on build stage * Faster CI * Tests for undo using keyboard shortcut 'z' (#7824) * Update @types/vscode (#7833) * Update vscode dependency * News entry * Fix focus problems with add new cell buttons (#7827) * Fix focus problems with add new cell buttons * Get rid of unnecessary delay for async callbacks * Use VSC API instead of hardcoding the uri resource vscode-resource (#7835) * Update vscode dependency * News entry * Stop hardcoding 'vscode-resource' and use VSC api * Remove jison dependency (#7863) * Another fix for focus on add (#7883) * Auto save native editor notebook (#7831) * Fix ctrl+s to work in the notebook editor (#7919) * Fix ctrl+s to work in the notebook editor * Fix linting error * More linter fixes * Cherry pick commit b6545e3 * Prevent updates to cell text when stauts of cell has changed (#7973) * Prevent updates to cell text when stauts of cell has changed * Added comments * When automatically opening the `Notebook Editor`, non file schemes (#7921) * Ensure we support live share * Copy *.trie files related to fontkit, as part of webpacking (#7978) * Cherry pick saving fix for ipynb files * new notebook command outside of extension (#7981) * Hide the parameters list when editor doesn't have focus (#7987) * Added comments * Fix max output size to be passed down to rendering (#8017) * Fix intellisense popping up in the wrong spot when first typing in a cell (#8018) * Fix markdown disappearing after editing and hitting the escape key. (#8047) * Fix markdown disappearing after editing and hitting the escape key. * Put back Don's hack * Fixes to allowing users to open a diff view for ipynb files (#8081) * Fixes to allowing users to open a diff view * Updated code review comments * Ensure metadata for notebooks are always present (#8109) * Ensure metadata for notebooks are always present * Let storage run in background * Refactor * Address code review * Do not auto save if notebook is untitled (#8095) * Do not auto save if notebook is untitled * Remove redundant code
1 parent 7ee8309 commit f0e234b

File tree

120 files changed

+4294
-1410
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

120 files changed

+4294
-1410
lines changed

build/ci/vscode-python-ci.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,8 +265,7 @@ stages:
265265

266266

267267
- stage: Smoke
268-
dependsOn:
269-
- Build
268+
dependsOn: []
270269
jobs:
271270
- job: 'Smoke'
272271
dependsOn: []

build/ci/vscode-python-pr-validation.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,7 @@ stages:
9393
- template: templates/test_phases.yml
9494

9595
- stage: Smoke
96-
dependsOn:
97-
- Build
96+
dependsOn: []
9897
jobs:
9998
- job: 'Smoke'
10099
dependsOn: []

build/webpack/webpack.extension.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ const config = {
6868
onEnd: [
6969
{
7070
copy: [
71+
{ source: './node_modules/fontkit/*.trie', destination: './out/client/node_modules' },
7172
{ source: './node_modules/pdfkit/js/data/*.*', destination: './out/client/node_modules/data' },
7273
{ source: './node_modules/pdfkit/js/pdfkit.js', destination: './out/client/node_modules/' }
7374
]

build/webpack/webpack.extension.config.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ const config: Configuration = {
7575
onEnd: [
7676
{
7777
copy: [
78+
{ source: './node_modules/fontkit/*.trie', destination: './out/client/node_modules' },
7879
{ source: './node_modules/pdfkit/js/data/*.*', destination: './out/client/node_modules/data' },
7980
{ source: './node_modules/pdfkit/js/pdfkit.js', destination: './out/client/node_modules/' }
8081
]

news/1 Enhancements/4441.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Support other variables for notebookFileRoot besides ${workspaceRoot}. Specifically allow things like ${fileDirName} so that the dir of the first file run in the interactive window is used for the current directory.

news/1 Enhancements/7800.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Add command palette commands for native editor (run all cells, run selected cell, add new cell). And remove interactive window commands from contexts where they don't apply.

news/1 Enhancements/7831.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Added ability to auto-save chagnes made to the notebook.

news/2 Fixes/7137.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix regression to allow connection to servers with no token and no password and add functional test for this scenario

news/2 Fixes/7483.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Perf improvements for opening notebooks with more than 100 cells.

news/2 Fixes/7569.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fix jupyter server startup hang when xeus-cling kernel is installed.

0 commit comments

Comments
 (0)