Unable to debug tests when using zsh

[dyc3]

Working on a PR for this

Environment data

• VS Code version: 1.44.0
• Extension version (available under the Extensions sidebar): 2020.4.76186
• OS and version: Ubuntu 18.04
• Python version (& distribution if applicable, e.g. Anaconda): 3.6
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda, and virtualenv
• Relevant/affected Python packages and their versions: unittest
• Relevant/affected Python-related VS Code extensions and their versions: N/A
• Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info How to update the language server to the latest stable version #3977): No
• Value of the python.languageServer setting: Microsoft
• Default shell: /bin/zsh

Expected behaviour

Expected to be able to debug tests.

Actual behaviour

Attempting to debug any tests runs this command to run the test with the debugger

 env DEBUGPY_LAUNCHER_PORT=33405 /home/carson/Documents/code/crystal/.env/bin/python /home/carson/.vscode/extensions/ms-python.python-2020.4.76186/pythonFiles/lib/python/debugpy/no_wheels/debugpy/launcher /home/carson/.vscode/extensions/ms-python.python-2020.4.76186/pythonFiles/visualstudio_py_testlauncher.py --us=./tests --up=test_*.py --uvInt=2 --result-port=43495

and results in the output:

zsh: no matches found: --up=test_*.py

with exit code 1

Steps to reproduce:

[NOTE: Self-contained, minimal reproducing code samples are extremely helpful and will expedite addressing your issue]

1. Use zsh as your default shell.
2. Attempt to debug any python unittest

Logs

Unnecessary

[dyc3]

I'm unable to reproduce this bug using vscode and the extension from git. Instead, I'm getting a different error in the developer console:

  ERR timeout after 1000 ms: Error: timeout after 1000 ms
    at t.RawDebugSession.handleErrorResponse (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:3044:67)
    at file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:3043:339
    at async t.RawDebugSession.shutdown (file:///usr/share/code/resources/app/out/vs/workbench/workbench.desktop.main.js:3041:336)
log.ts:197   ERR Language client is not ready yet: Error: Language client is not ready yet
	at LanguageClient.sendRequest (/home/carson/Documents/code/other/vscode-python/node_modules/vscode-languageclient/lib/client.js:1800:19)
	at LanguageServerSymbolProvider.provideDocumentSymbols (/home/carson/Documents/code/other/vscode-python/out/client/providers/symbolProvider.js:52:47)
	at TestFileCodeLensProvider.getCodeLenses (/home/carson/Documents/code/other/vscode-python/out/client/testing/codeLenses/testFiles.js:66:51)
	at TestFileCodeLensProvider.provideCodeLenses (/home/carson/Documents/code/other/vscode-python/out/client/testing/codeLenses/testFiles.js:42:21)
	at /usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:627:424
	at /usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:54:761
	at new Promise (<anonymous>)
	at Object.asPromise (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:54:733)
	at e.provideCodeLenses (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:627:395)
	at /usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:650:467
	at e._withAdapter (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:649:159)
	at e.$provideCodeLenses (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:650:445)
	at e._doInvokeHandler (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:752:683)
	at e._invokeHandler (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:752:375)
	at e._receiveRequest (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:750:953)
	at e._receiveOneMessage (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:749:832)
	at /usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:748:34
	at e.fire (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:48:497)
	at v.fire (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:206:615)
	at /usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:919:744
	at e.fire (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:48:497)
	at v.fire (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:206:615)
	at Object._receiveMessage (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:211:17)
	at /usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:208:155
	at e.fire (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:48:497)
	at p.acceptChunk (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:204:129)
	at /usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:203:483
	at Socket.t (/usr/share/code/resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:212:565)
	at Socket.emit (events.js:203:13)
	at addChunk (_stream_readable.js:295:12)
	at readableAddChunk (_stream_readable.js:276:11)
	at Socket.push (_stream_readable.js:210:10)
	at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)```

[dyc3]

I created a PR with what should be the fix anyway, because it was fairly trivial.

[ericsnowcurrently]

Thanks for the report, @dyc3. We're going to work on a fix.

This bug is due to a recent change in how debugpy handles args in the launch config. Before it passed them directly from the launch config to spawn(). Now it passed them through the launcher script, where they get shell expanded.

To solve this we will need to add a flag to the launch config that tells debugpy to do things the old way. Then we will set that flag in the appropriate code in src/client/testing/unittest/runner.ts.