Skip to content

Do not write disableSmartSend to workspace settings #22541

@isidorn

Description

@isidorn

Testing #22536

  1. Follow steps from the test plan item
  2. Notice notification with the Disable Smart Send button.
  3. Click on the smart send button
  4. This setting is written in workspace settings 🐛

We should not use workspace settings for this, as this is a user preference. Writing to workspace settings enforces it on the whole team that uses that repository, and makes a dirty git change.

I suggest to instead use user settings. Or local storage.

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugneeds community feedbackAwaiting community feedback

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions