Skip to content

Conversation

@Malix-Labs
Copy link

@Malix-Labs Malix-Labs commented Sep 28, 2024

Closes #24204

This is an appending to a bulk, it might be to wide, please see each line as an individual review

Related

@Malix-Labs Malix-Labs changed the title feat: ignoreSync feat: ignoreSync Sep 28, 2024
@Malix-Labs Malix-Labs marked this pull request as ready for review September 28, 2024 15:41
@karthiknadig karthiknadig self-assigned this Sep 28, 2024
@karthiknadig karthiknadig added the feature-request Request for new features or functionality label Sep 28, 2024
@karthiknadig karthiknadig added this to the October 2024 milestone Sep 28, 2024
@karthiknadig karthiknadig changed the title feat: ignoreSync Set ignoreSync on settings that are paths Sep 28, 2024
@Malix-Labs
Copy link
Author

I couldn't find the difference between ignoreSync and the "machine" scope, so I will first wait for vscode's clarification (see microsoft/vscode-docs#7638)

Reverting to draft

@Malix-Labs Malix-Labs marked this pull request as draft September 29, 2024 15:28
@karthiknadig karthiknadig added the skip package*.json package.json and package-lock.json don't both need updating label Sep 30, 2024
@karthiknadig
Copy link
Member

Thanks for the PR 🎉! This is very useful update to the settings ⚙️. We will review it when it is ready 🙂. Happy Coding!

@rzhao271 rzhao271 modified the milestones: October 2024, November 2024 Oct 25, 2024
@karthiknadig karthiknadig removed this from the February 2025 milestone Feb 25, 2025
@Malix-Labs
Copy link
Author

Closing because I do not want to break anything but please consider the changes I proposed!

Check microsoft/pyright#9105 and microsoft/vscode-docs#7638

@Malix-Labs Malix-Labs closed this Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request Request for new features or functionality skip package*.json package.json and package-lock.json don't both need updating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ignoreSync for path settings element

3 participants