Run Selected Text in Active Terminal gives IndentationError with IPython

[iutlu]

Environment data

• VS Code version: 1.40.2
• Extension version (available under the Extensions sidebar): 2019.11.50794
• OS and version: macOS Catalina 10.15.1
• Python version (& distribution if applicable, e.g. Anaconda): 3.7.5 Anaconda defaults
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
• Relevant/affected Python packages and their versions: XXX
• Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info How to update the language server to the latest stable version #3977): Language Server

Expected behaviour

Selecting some text and running the command "Terminal: Run Selected Text In Active Terminal" properly pastes the selection to an IPython console.

Actual behaviour

IndentationError is received.

Steps to reproduce:

1. Launch IPython in the built-in terminal. Then open some file in the editor; type and select

for x in range(3):
    print(x)
    break

2. Execute the command "Terminal: Run Selected Text in Active Terminal"

The following error is received:

In [1]: for x in range(3): 
   ...:         print(x) 
   ...:             break                                                                              
  File "<ipython-input-1-6c59f84e067e>", line 3
    break
    ^
IndentationError: unexpected indent

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

No output

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

No output

[iutlu]

A few more notes: The regular Python prompt is OK. Also, I've used IPython + Run Selected Text with my Windows machine for quite a few months with no issues. I've recently moved to a Mac and I've run into this bug just now. I cannot test with Windows at the moment so I'm not sure if this is a Windows vs. Mac issue, or a general regression.

[iutlu]

I've checked this on Windows (the same VSCode & Python extension versions), the problem is not there. So possibly it's macOS specific?

[ericsnowcurrently]

Thanks for getting in touch with us about this, @iutlu. The Terminal: Run Selected Text In Active Terminal command is from VS Code and doesn't know about Python code. For Python you want to use the Python: Run Selection/Line in Python Terminal command.

[iutlu]

Thanks. I've experimented a bit more, this time with the command from the Python extension (Python: Run Selection/Line in Python Terminal), and have concluded that the issue is with IPython support, regardless of the use of Python: ... vs Terminal: ...

Specifically if you do the following:

1. Select some arbitrary text, execute Python: Run Selection/Line in Python Terminal -- now you have a "Python Terminal" in this terminal instance.
2. exit() this prompt, now you have a regular shell prompt in this current terminal instance.
3. Launch ipython here

Now, the Python: Run Selection ... command does send the selection to the IPython prompt, but we again have the same indentation issue.

So my question is,

1. For both commands (Terminal: ... and Python: ...) it appears that the behavior is the same. Does the Python extension currently rely on the same underpinnings for the "send selection" behavior as VSCode proper?
2. If so, could the extension customize its own command so that it works better with IPython (I think the problem is due to some issue with handling newlines)

Thank you again for your time!

[ericsnowcurrently]

Ah, thanks for the clarification. We'll look into this further.