Add customizable interpreter discovery timeout #24227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@microsoft-github-policy-service agree company="Uber" |
mnoah1
force-pushed
the
adjust-interpreter-timeout
branch
from
3511d12 to
681a73f
Compare
mnoah1
force-pushed
the
adjust-interpreter-timeout
branch
from
681a73f to
0c318bc
Compare
mnoah1
changed the title
mnoah1
changed the title
karthiknadig
approved these changes
Oct 7, 2024
karthiknadig
added
bug
anthonykim1
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #24226
This adds a way to customize the timeout for the interpreter info script to run, by customizing the duration of the
VSC_PYTHON_INTERPRETER_INFO_TIMEOUTenvironment variable.This is to address setups (e.g. a monorepo with Bazel) where the hard coded 15 seconds is insufficient, as the first Python run also includes additional setup work to ensure the venv is available for use before the interpreter can actually execute.
This is being done via env var instead of via a VS Code setting to avoid introducing additional settings that will be deprecated after other planned upcoming work on interpreter discovery (see discussion on 24226).