Skip to content

Remove quotes from select interpreter lists #24603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove quotes from select interpreter lists #24603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/client/interpreter/configuration/interpreterSelector/interpreterSelector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,17 @@ export class InterpreterSelector implements IInterpreterSelector {
const interpreters = this.interpreterManager.getInterpreters(resource);
interpreters.sort(this.envTypeComparer.compare.bind(this.envTypeComparer));

return interpreters.map((item) => this.suggestionToQuickPickItem(item, resource, useFullDisplayName));
const interpreterLists = interpreters.map((item) =>
this.suggestionToQuickPickItem(item, resource, useFullDisplayName),
);
// Truncate ' ' inside parenthesis for Select Interpreter Lists.
for (const singleInterpreter of interpreterLists) {
if (singleInterpreter.label.includes('(') && singleInterpreter.label.includes(')')) {
Copy link
Member

@karthiknadig karthiknadig Dec 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right change. You should be able to find where this is set by following where label is set.

singleInterpreter.label = singleInterpreter.label.replace(/'/g, '');
}
}

return interpreterLists;
}

public async getAllSuggestions(resource: Resource): Promise<IInterpreterQuickPickItem[]> {
Expand Down
Loading