fix: memory leak when scrolling in notebook (#200447)

SimonSiefke · web-flow · commit 358f15fb9bbc · 2023-12-12T23:13:57.000Z
* fix: memory leak when scrolling in notebook

* remove unused code

* remove unused code

* remove unused code
diff --git a/src/vs/platform/actions/browser/menuEntryActionViewItem.ts b/src/vs/platform/actions/browser/menuEntryActionViewItem.ts
@@ -381,11 +381,11 @@ export class DropdownWithDefaultActionViewItem extends BaseActionViewItem {
 		};
 
 		this._dropdown = new DropdownMenuActionViewItem(submenuAction, submenuAction.actions, this._contextMenuService, dropdownOptions);
-		this._dropdown.actionRunner.onDidRun((e: IRunEvent) => {
+		this._register(this._dropdown.actionRunner.onDidRun((e: IRunEvent) => {
 			if (e.action instanceof MenuItemAction) {
 				this.update(e.action);
 			}
-		});
+		}));
 	}
 
 	private update(lastAction: MenuItemAction): void {

Original file line number	Diff line number	Diff line change
`@@ -381,11 +381,11 @@ export class DropdownWithDefaultActionViewItem extends BaseActionViewItem {`
`381`	`381`	`};`
`382`	`382`
`383`	`383`	`this._dropdown = new DropdownMenuActionViewItem(submenuAction, submenuAction.actions, this._contextMenuService, dropdownOptions);`
`384`		`- this._dropdown.actionRunner.onDidRun((e: IRunEvent) => {`
	`384`	`+ this._register(this._dropdown.actionRunner.onDidRun((e: IRunEvent) => {`
`385`	`385`	`if (e.action instanceof MenuItemAction) {`
`386`	`386`	`this.update(e.action);`
`387`	`387`	`}`
`388`		`- });`
	`388`	`+ }));`
`389`	`389`	`}`
`390`	`390`
`391`	`391`	`private update(lastAction: MenuItemAction): void {`