Merge pull request #298188 from microsoft/isidorn/industrial-chipmunk

remove suggested actions from chat view

Author: isidorn

src/vs/workbench/contrib/chat/browser/viewsWelcome/chatViewWelcomeController.ts

@@ -6,31 +6,23 @@
 import { asCSSUrl } from '../../../../../base/browser/cssValue.js';
 import * as dom from '../../../../../base/browser/dom.js';
 import { createCSSRule } from '../../../../../base/browser/domStylesheets.js';
-import { StandardKeyboardEvent } from '../../../../../base/browser/keyboardEvent.js';
 import { IRenderedMarkdown } from '../../../../../base/browser/markdownRenderer.js';
 import { Button } from '../../../../../base/browser/ui/button/button.js';
 import { renderIcon } from '../../../../../base/browser/ui/iconLabel/iconLabels.js';
-import { Action, IAction } from '../../../../../base/common/actions.js';
-import { Codicon } from '../../../../../base/common/codicons.js';
 import { Event } from '../../../../../base/common/event.js';
 import { StringSHA1 } from '../../../../../base/common/hash.js';
 import { IMarkdownString } from '../../../../../base/common/htmlContent.js';
-import { KeyCode } from '../../../../../base/common/keyCodes.js';
 import { Disposable, DisposableStore } from '../../../../../base/common/lifecycle.js';
 import { IObservable, ISettableObservable, observableValue } from '../../../../../base/common/observable.js';
 import { ThemeIcon } from '../../../../../base/common/themables.js';
 import { URI } from '../../../../../base/common/uri.js';
-import { localize } from '../../../../../nls.js';
 import { IContextKeyService } from '../../../../../platform/contextkey/common/contextkey.js';
-import { IContextMenuService } from '../../../../../platform/contextview/browser/contextView.js';
 import { IInstantiationService } from '../../../../../platform/instantiation/common/instantiation.js';
 import { ILogService } from '../../../../../platform/log/common/log.js';
 import { IMarkdownRendererService } from '../../../../../platform/markdown/browser/markdownRenderer.js';
 import { IOpenerService } from '../../../../../platform/opener/common/opener.js';
-import { ITelemetryService } from '../../../../../platform/telemetry/common/telemetry.js';
 import { defaultButtonStyles } from '../../../../../platform/theme/browser/defaultStyles.js';
 import { ChatAgentLocation } from '../../common/constants.js';
-import { IChatWidgetService } from '../chat.js';
 import { chatViewsWelcomeRegistry, IChatViewsWelcomeDescriptor } from './chatViewsWelcome.js';
 
 const $ = dom.$;
@@ -133,18 +125,9 @@ export interface IChatViewWelcomeContent {
 	readonly additionalMessage?: string | IMarkdownString;
 	tips?: IMarkdownString;
 	readonly inputPart?: HTMLElement;
-	readonly suggestedPrompts?: readonly IChatSuggestedPrompts[];
 	readonly useLargeIcon?: boolean;
 }
 
-export interface IChatSuggestedPrompts {
-	readonly icon?: ThemeIcon;
-	readonly label: string;
-	readonly description?: string;
-	readonly prompt: string;
-	readonly uri?: URI;
-}
-
 export interface IChatViewWelcomeRenderOptions {
 	readonly firstLinkToButton?: boolean;
 	readonly location: ChatAgentLocation;
@@ -159,10 +142,7 @@ export class ChatViewWelcomePart extends Disposable {
 		options: IChatViewWelcomeRenderOptions | undefined,
 		@IOpenerService private openerService: IOpenerService,
 		@ILogService private logService: ILogService,
-		@IChatWidgetService private chatWidgetService: IChatWidgetService,
-		@ITelemetryService private telemetryService: ITelemetryService,
 		@IMarkdownRendererService private readonly markdownRendererService: IMarkdownRendererService,
-		@IContextMenuService private readonly contextMenuService: IContextMenuService,
 	) {
 		super();
 
@@ -213,88 +193,6 @@ export class ChatViewWelcomePart extends Disposable {
 				}
 			}
 
-			// Render suggested prompts for both new user and regular modes
-			if (content.suggestedPrompts && content.suggestedPrompts.length) {
-				const suggestedPromptsContainer = dom.append(this.element, $('.chat-welcome-view-suggested-prompts'));
-				const titleElement = dom.append(suggestedPromptsContainer, $('.chat-welcome-view-suggested-prompts-title'));
-				titleElement.textContent = localize('chatWidget.suggestedActions', 'Suggested Actions');
-
-				for (const prompt of content.suggestedPrompts) {
-					const promptElement = dom.append(suggestedPromptsContainer, $('.chat-welcome-view-suggested-prompt'));
-					// Make the prompt element keyboard accessible
-					promptElement.setAttribute('role', 'button');
-					promptElement.setAttribute('tabindex', '0');
-					const promptAriaLabel = prompt.description
-						? localize('suggestedPromptAriaLabelWithDescription', 'Suggested prompt: {0}, {1}', prompt.label, prompt.description)
-						: localize('suggestedPromptAriaLabel', 'Suggested prompt: {0}', prompt.label);
-					promptElement.setAttribute('aria-label', promptAriaLabel);
-					const titleElement = dom.append(promptElement, $('.chat-welcome-view-suggested-prompt-title'));
-					titleElement.textContent = prompt.label;
-					const tooltip = localize('runPromptTitle', "Suggested prompt: {0}", prompt.prompt);
-					promptElement.title = tooltip;
-					titleElement.title = tooltip;
-					if (prompt.description) {
-						const descriptionElement = dom.append(promptElement, $('.chat-welcome-view-suggested-prompt-description'));
-						descriptionElement.textContent = prompt.description;
-						descriptionElement.title = prompt.description;
-					}
-					const executePrompt = () => {
-						type SuggestedPromptClickEvent = { suggestedPrompt: string };
-
-						type SuggestedPromptClickData = {
-							owner: 'bhavyaus';
-							comment: 'Event used to gain insights into when suggested prompts are clicked.';
-							suggestedPrompt: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The suggested prompt clicked.' };
-						};
-
-						this.telemetryService.publicLog2<SuggestedPromptClickEvent, SuggestedPromptClickData>('chat.clickedSuggestedPrompt', {
-							suggestedPrompt: prompt.prompt,
-						});
-
-						if (!this.chatWidgetService.lastFocusedWidget) {
-							const widgets = this.chatWidgetService.getWidgetsByLocations(ChatAgentLocation.Chat);
-							if (widgets.length) {
-								widgets[0].setInput(prompt.prompt);
-							}
-						} else {
-							this.chatWidgetService.lastFocusedWidget.setInput(prompt.prompt);
-						}
-					};
-					// Add context menu handler
-					this._register(dom.addDisposableListener(promptElement, dom.EventType.CONTEXT_MENU, (e: MouseEvent) => {
-						e.preventDefault();
-						e.stopImmediatePropagation();
-
-						const actions = this.getPromptContextMenuActions(prompt);
-
-						this.contextMenuService.showContextMenu({
-							getAnchor: () => ({ x: e.clientX, y: e.clientY }),
-							getActions: () => actions,
-						});
-					}));
-					// Add click handler
-					this._register(dom.addDisposableListener(promptElement, dom.EventType.CLICK, executePrompt));
-					// Add keyboard handler
-					this._register(dom.addDisposableListener(promptElement, dom.EventType.KEY_DOWN, (e) => {
-						const event = new StandardKeyboardEvent(e);
-						if (event.equals(KeyCode.Enter) || event.equals(KeyCode.Space)) {
-							e.preventDefault();
-							e.stopPropagation();
-							executePrompt();
-						}
-						else if (event.equals(KeyCode.F10) && event.shiftKey) {
-							e.preventDefault();
-							e.stopPropagation();
-							const actions = this.getPromptContextMenuActions(prompt);
-							this.contextMenuService.showContextMenu({
-								getAnchor: () => promptElement,
-								getActions: () => actions,
-							});
-						}
-					}));
-				}
-			}
-
 			// Tips
 			if (content.tips) {
 				const tips = dom.append(this.element, $('.chat-welcome-view-tips'));
@@ -306,39 +204,13 @@ export class ChatViewWelcomePart extends Disposable {
 		}
 	}
 
-	private getPromptContextMenuActions(prompt: IChatSuggestedPrompts): IAction[] {
-		const actions: IAction[] = [];
-		if (prompt.uri) {
-			const uri = prompt.uri;
-			actions.push(new Action(
-				'chat.editPromptFile',
-				localize('editPromptFile', "Edit Prompt File"),
-				ThemeIcon.asClassName(Codicon.goToFile),
-				true,
-				async () => {
-					try {
-						await this.openerService.open(uri);
-					} catch (error) {
-						this.logService.error('Failed to open prompt file:', error);
-					}
-				}
-			));
-		}
-		return actions;
-	}
-
 	public needsRerender(content: IChatViewWelcomeContent): boolean {
 		// Heuristic based on content that changes between states
 		return !!(
 			this.content.title !== content.title ||
 			this.content.message.value !== content.message.value ||
 			this.content.additionalMessage !== content.additionalMessage ||
-			this.content.tips?.value !== content.tips?.value ||
-			this.content.suggestedPrompts?.length !== content.suggestedPrompts?.length ||
-			this.content.suggestedPrompts?.some((prompt, index) => {
-				const incoming = content.suggestedPrompts?.[index];
-				return incoming?.label !== prompt.label || incoming?.description !== prompt.description;
-			}));
+			this.content.tips?.value !== content.tips?.value);
 	}
 
 	private renderMarkdownMessageContent(content: IMarkdownString, options: IChatViewWelcomeRenderOptions | undefined): IRenderedMarkdown {