Skip to content

Commit 59f3e6f

Browse files
meganroggeeli-w-king
authored andcommitted
add New Chat alert, remove will continue in bg as it's no longer needed and can override other (#286837)
1 parent 6f17a67 commit 59f3e6f

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/vs/workbench/contrib/chat/browser/accessibility/chatAccessibilityService.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ export class ChatAccessibilityService extends Disposable implements IChatAccessi
5050
if (!requestInProgress) {
5151
return;
5252
}
53-
alert(localize('chat.backgroundRequest', "Chat session will continue in the background."));
5453
this.disposeRequest(e);
5554
}));
5655
}

src/vs/workbench/contrib/chat/browser/actions/chatNewActions.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
import { Codicon } from '../../../../../base/common/codicons.js';
77
import { KeyCode, KeyMod } from '../../../../../base/common/keyCodes.js';
88
import { ServicesAccessor } from '../../../../../editor/browser/editorExtensions.js';
9-
import { localize2 } from '../../../../../nls.js';
9+
import { localize, localize2 } from '../../../../../nls.js';
10+
import { IAccessibilityService } from '../../../../../platform/accessibility/common/accessibility.js';
1011
import { Action2, MenuId, MenuRegistry, registerAction2 } from '../../../../../platform/actions/common/actions.js';
1112
import { CommandsRegistry } from '../../../../../platform/commands/common/commands.js';
1213
import { ContextKeyExpr } from '../../../../../platform/contextkey/common/contextkey.js';
@@ -112,6 +113,8 @@ export function registerNewChatActions() {
112113
}
113114

114115
async run(accessor: ServicesAccessor, ...args: unknown[]) {
116+
const accessibilityService = accessor.get(IAccessibilityService);
117+
115118
const executeCommandContext = args[0] as INewEditSessionActionContext | undefined;
116119

117120
// Context from toolbar or lastFocusedWidget
@@ -134,6 +137,8 @@ export function registerNewChatActions() {
134137
widget.input.relatedFiles?.clear();
135138
widget.focusInput();
136139

140+
accessibilityService.alert(localize('newChat', "New chat"));
141+
137142
if (!executeCommandContext) {
138143
return;
139144
}

0 commit comments

Comments
 (0)