Skip to content

Commit 5f74645

Browse files
committed
address some comments
1 parent 06ff706 commit 5f74645

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

src/vs/workbench/contrib/chat/browser/chatInputPart.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
220220
private attachmentsContainer!: HTMLElement;
221221

222222
private chatInputOverlay!: HTMLElement;
223-
private _overlayClickListener: IDisposable | undefined;
223+
private readonly _overlayClickListener = this._register(new MutableDisposable<IDisposable>());
224224

225225
private attachedContextContainer!: HTMLElement;
226226
private readonly attachedContextDisposables: MutableDisposable<DisposableStore>;
@@ -1308,15 +1308,13 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
13081308
public toggleChatInputOverlay(editing: boolean): void {
13091309
this.chatInputOverlay.classList.toggle('disabled', editing);
13101310
if (editing) {
1311-
this._overlayClickListener?.dispose();
1312-
this._overlayClickListener = this._register(dom.addStandardDisposableListener(this.chatInputOverlay, dom.EventType.CLICK, e => {
1311+
this._overlayClickListener.value = dom.addStandardDisposableListener(this.chatInputOverlay, dom.EventType.CLICK, e => {
13131312
e.preventDefault();
13141313
e.stopPropagation();
13151314
this._onDidClickOverlay.fire();
1316-
}));
1315+
});
13171316
} else {
1318-
this._overlayClickListener?.dispose();
1319-
this._overlayClickListener = undefined;
1317+
this._overlayClickListener.clear();
13201318
}
13211319
}
13221320

src/vs/workbench/contrib/chat/browser/media/chat.css

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2345,7 +2345,6 @@ have to be updated for changes to the rules above, or to support more deeply nes
23452345
display: flex;
23462346
z-index: 101;
23472347
user-select: none;
2348-
pointer-events: auto;
23492348
cursor: default;
23502349
}
23512350

0 commit comments

Comments
 (0)