fix accessibility signals bug (#214795)

fix #214698

Author: meganrogge

src/vs/platform/accessibilitySignal/browser/accessibilitySignalService.ts

@@ -26,7 +26,7 @@ export interface IAccessibilitySignalService {
 	playSignalLoop(signal: AccessibilitySignal, milliseconds: number): IDisposable;
 
 	getEnabledState(signal: AccessibilitySignal, userGesture: boolean, modality?: AccessibilityModality | undefined): IValueWithChangeEvent<boolean>;
-	getDelayMs(signal: AccessibilitySignal, modality: AccessibilityModality): number;
+	getDelayMs(signal: AccessibilitySignal, modality: AccessibilityModality, mode: 'line' | 'positional'): number;
 	/**
 	 * Avoid this method and prefer `.playSignal`!
 	 * Only use it when you want to play the sound regardless of enablement, e.g. in the settings quick pick.
@@ -241,10 +241,20 @@ export class AccessibilitySignalService extends Disposable implements IAccessibi
 		return this.getEnabledState(signal, false).onDidChange;
 	}
 
-	public getDelayMs(signal: AccessibilitySignal, modality: AccessibilityModality): number {
-		const delaySettingsKey = signal.delaySettingsKey ?? 'accessibility.signalOptions.delays.general';
-		const delaySettingsValue: { sound: number; announcement: number } = this.configurationService.getValue(delaySettingsKey);
-		return modality === 'sound' ? delaySettingsValue.sound : delaySettingsValue.announcement;
+	public getDelayMs(signal: AccessibilitySignal, modality: AccessibilityModality, mode: 'line' | 'positional'): number {
+		const options: { debouncePositionChanges: boolean; 'experimental.delays': { general: { sound: number; announcement: number }; errorAtPosition: { sound: number; announcement: number }; warningAtPosition: { sound: number; announcement: number } } } = this.configurationService.getValue('accessibility.signalOptions');
+		if (!options || !options.debouncePositionChanges) {
+			return 0;
+		}
+		let value: { sound: number; announcement: number };
+		if (signal.name === AccessibilitySignal.errorAtPosition.name && mode === 'positional') {
+			value = options['experimental.delays'].errorAtPosition;
+		} else if (signal.name === AccessibilitySignal.warningAtPosition.name && mode === 'positional') {
+			value = options['experimental.delays'].warningAtPosition;
+		} else {
+			value = options['experimental.delays'].general;
+		}
+		return modality === 'sound' ? value.sound : value.announcement;
 	}
 }
 

src/vs/workbench/contrib/accessibilitySignals/browser/editorTextPropertySignalsContribution.ts

@@ -104,7 +104,7 @@ export class EditorTextPropertySignalsContribution extends Disposable implements
 
 				for (const modality of ['sound', 'announcement'] as AccessibilityModality[]) {
 					if (this._accessibilitySignalService.getEnabledState(signal, false, modality).value) {
-						const delay = this._accessibilitySignalService.getDelayMs(signal, modality) + (didType.get() ? 1000 : 0);
+						const delay = this._accessibilitySignalService.getDelayMs(signal, modality, mode) + (didType.get() ? 1000 : 0);
 
 						timeouts.add(disposableTimeout(() => {
 							if (source.isPresent(position, mode, undefined)) {