Skip to content

Commit 7027856

Browse files
authored
sessions - allow callback scheme in auth (#298270)
1 parent 5e2614b commit 7027856

File tree

2 files changed

+8
-2
lines changed
  • extensions
    • github-authentication/src/common
    • microsoft-authentication/src/common

2 files changed

+8
-2
lines changed

extensions/github-authentication/src/common/env.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,15 @@ import { AuthProviderType } from '../github';
88
const VALID_DESKTOP_CALLBACK_SCHEMES = [
99
'vscode',
1010
'vscode-insiders',
11+
'vscode-exploration',
12+
'vscode-sessions',
13+
'vscode-sessions-insiders',
14+
'vscode-sessions-exploration',
1115
// On Windows, some browsers don't seem to redirect back to OSS properly.
1216
// As a result, you get stuck in the auth flow. We exclude this from the
1317
// list until we can figure out a way to fix this behavior in browsers.
1418
// 'code-oss',
1519
'vscode-wsl',
16-
'vscode-exploration'
1720
];
1821

1922
export function isSupportedClient(uri: Uri): boolean {

extensions/microsoft-authentication/src/common/env.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,15 @@ export const DEFAULT_REDIRECT_URI = 'https://vscode.dev/redirect';
99
const VALID_DESKTOP_CALLBACK_SCHEMES = [
1010
'vscode',
1111
'vscode-insiders',
12+
'vscode-exploration',
13+
'vscode-sessions',
14+
'vscode-sessions-insiders',
15+
'vscode-sessions-exploration',
1216
// On Windows, some browsers don't seem to redirect back to OSS properly.
1317
// As a result, you get stuck in the auth flow. We exclude this from the
1418
// list until we can figure out a way to fix this behavior in browsers.
1519
// 'code-oss',
1620
'vscode-wsl',
17-
'vscode-exploration'
1821
];
1922

2023
export function isSupportedClient(uri: Uri): boolean {

0 commit comments

Comments
 (0)