sessions - specific auth branding for auth redirect (#298277)

Author: bpasero

extensions/github-authentication/media/index.html

@@ -30,9 +30,17 @@ <h1 class="title">Launching <span class="app-name"></span></h1>
 	</div>
 	<script>
 		const urlParams = new URLSearchParams(window.location.search);
+
 		const appName = urlParams.get('app_name');
 		document.querySelectorAll('.app-name').forEach(e => e.innerText = appName);
 
+		if (urlParams.get('app_is_sessions') === 'true') {
+			const iconImg = document.querySelector('.icon-container img');
+			if (iconImg) {
+				iconImg.src = 'sessions-icon.svg';
+			}
+		}
+
 		// if name contains 'insiders', update filter CSS variables
 		if (appName.toLowerCase().includes('insiders')) {
 			document.documentElement.style.setProperty('--vscode-filter-0', 'var(--vscode-insiders-filter-0)');

extensions/github-authentication/media/sessions-icon.svg

@@ -19,7 +19,8 @@
   ],
   "enabledApiProposals": [
     "authIssuers",
-    "authProviderSpecific"
+    "authProviderSpecific",
+    "agentSessionsWorkspace"
   ],
   "activationEvents": [],
   "capabilities": {

extensions/github-authentication/package.json

@@ -7,7 +7,7 @@ import { URL } from 'url';
 import * as fs from 'fs';
 import * as path from 'path';
 import { randomBytes } from 'crypto';
-import { env } from 'vscode';
+import { env, workspace } from 'vscode';
 
 function sendFile(res: http.ServerResponse, filepath: string) {
 	const isSvg = filepath.endsWith('.svg');
@@ -99,13 +99,14 @@ export class LoopbackAuthServer implements ILoopbackServer {
 		this._resultPromise = new Promise<IOAuthResult>((resolve, reject) => deferred = { resolve, reject });
 
 		const appNameQueryParam = `&app_name=${encodeURIComponent(env.appName)}`;
+		const appIsSessionsQueryParam = workspace.isAgentSessionsWorkspace ? '&app_is_sessions=true' : '';
 		this._server = http.createServer((req, res) => {
 			const reqUrl = new URL(req.url!, `http://${req.headers.host}`);
 			switch (reqUrl.pathname) {
 				case '/signin': {
 					const receivedNonce = (reqUrl.searchParams.get('nonce') ?? '').replace(/ /g, '+');
 					if (receivedNonce !== this.nonce) {
-						res.writeHead(302, { location: `/?error=${encodeURIComponent('Nonce does not match.')}${appNameQueryParam}` });
+						res.writeHead(302, { location: `/?error=${encodeURIComponent('Nonce does not match.')}${appNameQueryParam}${appIsSessionsQueryParam}` });
 						res.end();
 					}
 					res.writeHead(302, { location: this._startingRedirect.toString() });
@@ -122,20 +123,20 @@ export class LoopbackAuthServer implements ILoopbackServer {
 						return;
 					}
 					if (this.state !== state) {
-						res.writeHead(302, { location: `/?error=${encodeURIComponent('State does not match.')}${appNameQueryParam}` });
+						res.writeHead(302, { location: `/?error=${encodeURIComponent('State does not match.')}${appNameQueryParam}${appIsSessionsQueryParam}` });
 						res.end();
 						throw new Error('State does not match.');
 					}
 					if (this.nonce !== nonce) {
-						res.writeHead(302, { location: `/?error=${encodeURIComponent('Nonce does not match.')}${appNameQueryParam}` });
+						res.writeHead(302, { location: `/?error=${encodeURIComponent('Nonce does not match.')}${appNameQueryParam}${appIsSessionsQueryParam}` });
 						res.end();
 						throw new Error('Nonce does not match.');
 					}
 					deferred.resolve({ code, state });
 					if (isPortable) {
-						res.writeHead(302, { location: `/?app_name=${encodeURIComponent(env.appName)}` });
+						res.writeHead(302, { location: `/?app_name=${encodeURIComponent(env.appName)}${appIsSessionsQueryParam}` });
 					} else {
-						res.writeHead(302, { location: `/?redirect_uri=${encodeURIComponent(callbackUri)}${appNameQueryParam}` });
+						res.writeHead(302, { location: `/?redirect_uri=${encodeURIComponent(callbackUri)}${appNameQueryParam}${appIsSessionsQueryParam}` });
 					}
 					res.end();
 					break;

extensions/github-authentication/src/node/authServer.ts

@@ -14,6 +14,7 @@
 		"src/**/*",
 		"../../src/vscode-dts/vscode.d.ts",
 		"../../src/vscode-dts/vscode.proposed.authIssuers.d.ts",
-		"../../src/vscode-dts/vscode.proposed.authProviderSpecific.d.ts"
+		"../../src/vscode-dts/vscode.proposed.authProviderSpecific.d.ts",
+		"../../src/vscode-dts/vscode.proposed.agentSessionsWorkspace.d.ts"
 	]
 }