agent sessions - make full list the default and change showing recent to a setting

bpasero · bpasero · commit 86bfa25df15c · 2026-01-16T16:43:50.000+01:00
diff --git a/src/vs/workbench/contrib/chat/browser/agentSessions/agentSessions.contribution.ts b/src/vs/workbench/contrib/chat/browser/agentSessions/agentSessions.contribution.ts
@@ -17,7 +17,7 @@ import { IAgentSessionsService, AgentSessionsService } from './agentSessionsServ
 import { LocalAgentsSessionsProvider } from './localAgentSessionsProvider.js';
 import { IWorkbenchContribution, registerWorkbenchContribution2, WorkbenchPhase } from '../../../../common/contributions.js';
 import { ISubmenuItem, MenuId, MenuRegistry, registerAction2, SubmenuItemAction } from '../../../../../platform/actions/common/actions.js';
-import { ArchiveAgentSessionAction, ArchiveAgentSessionSectionAction, UnarchiveAgentSessionSectionAction, UnarchiveAgentSessionAction, OpenAgentSessionInEditorGroupAction, OpenAgentSessionInNewEditorGroupAction, OpenAgentSessionInNewWindowAction, ShowAgentSessionsSidebar, HideAgentSessionsSidebar, ToggleAgentSessionsSidebar, RefreshAgentSessionsViewerAction, FindAgentSessionInViewerAction, MarkAgentSessionUnreadAction, MarkAgentSessionReadAction, MarkAgentSessionSectionReadAction, FocusAgentSessionsAction, SetAgentSessionsOrientationStackedAction, SetAgentSessionsOrientationSideBySideAction, ToggleChatViewSessionsAction, PickAgentSessionAction, ArchiveAllAgentSessionsAction, RenameAgentSessionAction, DeleteAgentSessionAction, DeleteAllLocalSessionsAction } from './agentSessionsActions.js';
+import { ArchiveAgentSessionAction, ArchiveAgentSessionSectionAction, UnarchiveAgentSessionSectionAction, UnarchiveAgentSessionAction, OpenAgentSessionInEditorGroupAction, OpenAgentSessionInNewEditorGroupAction, OpenAgentSessionInNewWindowAction, ShowAgentSessionsSidebar, HideAgentSessionsSidebar, ToggleAgentSessionsSidebar, RefreshAgentSessionsViewerAction, FindAgentSessionInViewerAction, MarkAgentSessionUnreadAction, MarkAgentSessionReadAction, MarkAgentSessionSectionReadAction, FocusAgentSessionsAction, SetAgentSessionsOrientationStackedAction, SetAgentSessionsOrientationSideBySideAction, ShowAllAgentSessionsAction, ShowRecentAgentSessionsAction, HideAgentSessionsAction, PickAgentSessionAction, ArchiveAllAgentSessionsAction, RenameAgentSessionAction, DeleteAgentSessionAction, DeleteAllLocalSessionsAction } from './agentSessionsActions.js';
 import { AgentSessionsQuickAccessProvider, AGENT_SESSIONS_QUICK_ACCESS_PREFIX } from './agentSessionsQuickAccess.js';
 import { IAgentSessionProjectionService, AgentSessionProjectionService } from './agentSessionProjectionService.js';
 import { EnterAgentSessionProjectionAction, ExitAgentSessionProjectionAction, ToggleAgentStatusAction, ToggleAgentSessionProjectionAction } from './agentSessionProjectionActions.js';
@@ -52,7 +52,9 @@ registerAction2(FindAgentSessionInViewerAction);
 registerAction2(ShowAgentSessionsSidebar);
 registerAction2(HideAgentSessionsSidebar);
 registerAction2(ToggleAgentSessionsSidebar);
-registerAction2(ToggleChatViewSessionsAction);
+registerAction2(ShowAllAgentSessionsAction);
+registerAction2(ShowRecentAgentSessionsAction);
+registerAction2(HideAgentSessionsAction);
 registerAction2(SetAgentSessionsOrientationStackedAction);
 registerAction2(SetAgentSessionsOrientationSideBySideAction);
 
diff --git a/src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsActions.ts b/src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsActions.ts
@@ -36,27 +36,86 @@ import { KeyCode, KeyMod } from '../../../../../base/common/keyCodes.js';
 
 //#region Chat View
 
-export class ToggleChatViewSessionsAction extends Action2 {
+const showSessionsSubmenu = new MenuId('chatShowSessionsSubmenu');
+MenuRegistry.appendMenuItem(MenuId.ChatWelcomeContext, {
+	submenu: showSessionsSubmenu,
+	title: localize2('chat.showSessions', "Show Sessions"),
+	group: '0_sessions',
+	order: 1,
+	when: ChatContextKeys.inChatEditor.negate()
+});
+
+export class ShowAllAgentSessionsAction extends Action2 {
 
 	constructor() {
 		super({
-			id: 'workbench.action.chat.toggleChatViewSessions',
-			title: localize2('chat.toggleChatViewSessions.label', "Show Sessions"),
-			toggled: ContextKeyExpr.equals(`config.${ChatConfiguration.ChatViewSessionsEnabled}`, true),
+			id: 'workbench.action.chat.showAllAgentSessions',
+			title: localize2('chat.showSessions.all', "All"),
+			toggled: ContextKeyExpr.and(
+				ContextKeyExpr.equals(`config.${ChatConfiguration.ChatViewSessionsEnabled}`, true),
+				ContextKeyExpr.equals(`config.${ChatConfiguration.ChatViewSessionsShowRecentOnly}`, false)
+			),
 			menu: {
-				id: MenuId.ChatWelcomeContext,
-				group: '0_sessions',
-				order: 1,
-				when: ChatContextKeys.inChatEditor.negate()
+				id: showSessionsSubmenu,
+				group: 'navigation',
+				order: 1
 			}
 		});
 	}
 
 	async run(accessor: ServicesAccessor): Promise<void> {
 		const configurationService = accessor.get(IConfigurationService);
 
-		const chatViewSessionsEnabled = configurationService.getValue<boolean>(ChatConfiguration.ChatViewSessionsEnabled);
-		await configurationService.updateValue(ChatConfiguration.ChatViewSessionsEnabled, !chatViewSessionsEnabled);
+		await configurationService.updateValue(ChatConfiguration.ChatViewSessionsEnabled, true);
+		await configurationService.updateValue(ChatConfiguration.ChatViewSessionsShowRecentOnly, false);
+	}
+}
+
+export class ShowRecentAgentSessionsAction extends Action2 {
+
+	constructor() {
+		super({
+			id: 'workbench.action.chat.showRecentAgentSessions',
+			title: localize2('chat.showSessions.recent', "Recent"),
+			toggled: ContextKeyExpr.and(
+				ContextKeyExpr.equals(`config.${ChatConfiguration.ChatViewSessionsEnabled}`, true),
+				ContextKeyExpr.equals(`config.${ChatConfiguration.ChatViewSessionsShowRecentOnly}`, true)
+			),
+			menu: {
+				id: showSessionsSubmenu,
+				group: 'navigation',
+				order: 2
+			}
+		});
+	}
+
+	async run(accessor: ServicesAccessor): Promise<void> {
+		const configurationService = accessor.get(IConfigurationService);
+
+		await configurationService.updateValue(ChatConfiguration.ChatViewSessionsEnabled, true);
+		await configurationService.updateValue(ChatConfiguration.ChatViewSessionsShowRecentOnly, true);
+	}
+}
+
+export class HideAgentSessionsAction extends Action2 {
+
+	constructor() {
+		super({
+			id: 'workbench.action.chat.hideAgentSessions',
+			title: localize2('chat.showSessions.none', "None"),
+			toggled: ContextKeyExpr.equals(`config.${ChatConfiguration.ChatViewSessionsEnabled}`, false),
+			menu: {
+				id: showSessionsSubmenu,
+				group: 'navigation',
+				order: 3
+			}
+		});
+	}
+
+	async run(accessor: ServicesAccessor): Promise<void> {
+		const configurationService = accessor.get(IConfigurationService);
+
+		await configurationService.updateValue(ChatConfiguration.ChatViewSessionsEnabled, false);
 	}
 }
 
diff --git a/src/vs/workbench/contrib/chat/browser/chat.contribution.ts b/src/vs/workbench/contrib/chat/browser/chat.contribution.ts
@@ -387,6 +387,11 @@ configurationRegistry.registerConfiguration({
 			default: true,
 			description: nls.localize('chat.viewSessions.enabled', "Show chat agent sessions when chat is empty or to the side when chat view is wide enough."),
 		},
+		[ChatConfiguration.ChatViewSessionsShowRecentOnly]: {
+			type: 'boolean',
+			default: false,
+			description: nls.localize('chat.viewSessions.showRecentOnly', "When enabled, only show recent sessions in the stacked sessions view. When disabled, show all sessions."),
+		},
 		[ChatConfiguration.ChatViewSessionsOrientation]: {
 			type: 'string',
 			enum: ['stacked', 'sideBySide'],
diff --git a/src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewPane.ts b/src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewPane.ts
@@ -50,7 +50,6 @@ import { ChatWidget } from '../../widget/chatWidget.js';
 import { ChatViewWelcomeController, IViewWelcomeDelegate } from '../../viewsWelcome/chatViewWelcomeController.js';
 import { IWorkbenchLayoutService, LayoutSettings, Position } from '../../../../../services/layout/browser/layoutService.js';
 import { AgentSessionsViewerOrientation, AgentSessionsViewerPosition } from '../../agentSessions/agentSessions.js';
-import { Link } from '../../../../../../platform/opener/browser/link.js';
 import { IProgressService } from '../../../../../../platform/progress/common/progress.js';
 import { ChatViewId } from '../../chat.js';
 import { disposableTimeout } from '../../../../../../base/common/async.js';
@@ -63,7 +62,6 @@ import { IChatEntitlementService } from '../../../../../services/chat/common/cha
 interface IChatViewPaneState extends Partial<IChatModelInputState> {
 	sessionId?: string;
 
-	sessionsViewerLimited?: boolean;
 	sessionsSidebarWidth?: number;
 }
 
@@ -123,7 +121,7 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
 		) {
 			this.viewState.sessionId = undefined; // clear persisted session on fresh start
 		}
-		this.sessionsViewerLimited = this.viewState.sessionsViewerLimited ?? true;
+		this.sessionsViewerLimited = this.configurationService.getValue<boolean>(ChatConfiguration.ChatViewSessionsShowRecentOnly) ?? false;
 		this.sessionsViewerVisible = false; // will be updated from layout code
 		this.sessionsViewerSidebarWidth = Math.max(ChatViewPane.SESSIONS_SIDEBAR_MIN_WIDTH, this.viewState.sessionsSidebarWidth ?? ChatViewPane.SESSIONS_SIDEBAR_DEFAULT_WIDTH);
 
@@ -214,6 +212,22 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
 			return e.affectsConfiguration(LayoutSettings.ACTIVITY_BAR_LOCATION);
 		})(() => this.updateViewPaneClasses(true)));
 
+		// Sessions viewer limited setting changes
+		this._register(Event.filter(this.configurationService.onDidChangeConfiguration, e => {
+			return e.affectsConfiguration(ChatConfiguration.ChatViewSessionsShowRecentOnly);
+		})(() => {
+			const oldSessionsViewerLimited = this.sessionsViewerLimited;
+			if (this.sessionsViewerOrientation === AgentSessionsViewerOrientation.SideBySide) {
+				this.sessionsViewerLimited = false; // side by side always shows all
+			} else {
+				this.sessionsViewerLimited = this.configurationService.getValue<boolean>(ChatConfiguration.ChatViewSessionsShowRecentOnly) ?? false;
+			}
+
+			if (oldSessionsViewerLimited !== this.sessionsViewerLimited) {
+				this.notifySessionsControlLimitedChanged(true /* layout */, true /* update */);
+			}
+		}));
+
 		// Entitlement changes
 		this._register(this.chatEntitlementService.onDidChangeSentiment(() => {
 			this.updateViewPaneClasses(true);
@@ -305,8 +319,6 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
 	private sessionsTitle: HTMLElement | undefined;
 	private sessionsControlContainer: HTMLElement | undefined;
 	private sessionsControl: AgentSessionsControl | undefined;
-	private sessionsLinkContainer: HTMLElement | undefined;
-	private sessionsLink: Link | undefined;
 	private sessionsCount = 0;
 	private sessionsViewerLimited: boolean;
 	private sessionsViewerVisible: boolean;
@@ -401,22 +413,6 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
 
 		sessionsToolbar.context = sessionsControl;
 
-		// Link to Sessions View
-		this.sessionsLinkContainer = append(sessionsContainer, $('.agent-sessions-link-container'));
-		this.sessionsLink = this._register(this.instantiationService.createInstance(Link, this.sessionsLinkContainer, {
-			label: this.sessionsViewerLimited ? localize('showAllSessions', "Show More") : localize('showRecentSessions', "Show Less"),
-			href: '',
-		}, {
-			opener: () => {
-				this.sessionsViewerLimited = !this.sessionsViewerLimited;
-				this.viewState.sessionsViewerLimited = this.sessionsViewerLimited;
-
-				this.notifySessionsControlLimitedChanged(true /* layout */, true /* update */);
-
-				sessionsControl.focus();
-			}
-		}));
-
 		// Deal with orientation configuration
 		this._register(Event.runAndSubscribe(Event.filter(this.configurationService.onDidChangeConfiguration, e => e.affectsConfiguration(ChatConfiguration.ChatViewSessionsOrientation)), e => {
 			const newSessionsViewerOrientationConfiguration = this.configurationService.getValue<'stacked' | 'sideBySide' | unknown>(ChatConfiguration.ChatViewSessionsOrientation);
@@ -463,13 +459,6 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
 
 		this.updateSessionsControlTitle();
 
-		if (this.sessionsLink) {
-			this.sessionsLink.link = {
-				label: this.sessionsViewerLimited ? localize('showAllSessions', "Show More") : localize('showRecentSessions', "Show Less"),
-				href: ''
-			};
-		}
-
 		const updatePromise = triggerUpdate ? this.sessionsControl?.update() : undefined;
 
 		if (triggerLayout) {
@@ -850,7 +839,7 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
 		let heightReduction = 0;
 		let widthReduction = 0;
 
-		if (!this.sessionsContainer || !this.sessionsControlContainer || !this.sessionsControl || !this.viewPaneContainer || !this.sessionsTitleContainer || !this.sessionsLinkContainer || !this.sessionsTitle || !this.sessionsLink) {
+		if (!this.sessionsContainer || !this.sessionsControlContainer || !this.sessionsControl || !this.viewPaneContainer || !this.sessionsTitleContainer || !this.sessionsTitle) {
 			return { heightReduction, widthReduction };
 		}
 
@@ -894,7 +883,7 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
 			if (this.sessionsViewerOrientation === AgentSessionsViewerOrientation.SideBySide) {
 				this.sessionsViewerLimited = false; // side by side always shows all
 			} else {
-				this.sessionsViewerLimited = this.viewState.sessionsViewerLimited ?? true;
+				this.sessionsViewerLimited = this.configurationService.getValue<boolean>(ChatConfiguration.ChatViewSessionsShowRecentOnly) ?? false;
 			}
 
 			let updatePromise: Promise<void>;
@@ -932,7 +921,7 @@ export class ChatViewPane extends ViewPane implements IViewWelcomeDelegate {
 			return { heightReduction: 0, widthReduction: 0 };
 		}
 
-		let availableSessionsHeight = height - this.sessionsTitleContainer.offsetHeight - this.sessionsLinkContainer.offsetHeight;
+		let availableSessionsHeight = height - this.sessionsTitleContainer.offsetHeight;
 		if (this.sessionsViewerOrientation === AgentSessionsViewerOrientation.Stacked) {
 			availableSessionsHeight -= Math.max(ChatViewPane.MIN_CHAT_WIDGET_HEIGHT, this._widget?.input?.contentHeight ?? 0);
 		}
diff --git a/src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/media/chatViewPane.css b/src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/media/chatViewPane.css
@@ -77,22 +77,6 @@
 			background-color: var(--vscode-inputOption-activeBackground);
 		}
 	}
-
-	.agent-sessions-link-container {
-		padding: 8px 0;
-		font-size: 12px;
-		text-align: center;
-	}
-
-	.agent-sessions-link-container a {
-		color: var(--vscode-descriptionForeground);
-	}
-
-	.agent-sessions-link-container a:hover,
-	.agent-sessions-link-container a:active {
-		text-decoration: none;
-		color: var(--vscode-textLink-foreground);
-	}
 }
 
 /* Sessions control: stacked */
@@ -121,11 +105,6 @@
 			border-left: 1px solid var(--vscode-panel-border);
 		}
 	}
-
-	.agent-sessions-link-container {
-		/* hide link to show more when side by side */
-		display: none;
-	}
 }
 
 /*
diff --git a/src/vs/workbench/contrib/chat/common/constants.ts b/src/vs/workbench/contrib/chat/common/constants.ts
@@ -28,6 +28,7 @@ export enum ChatConfiguration {
 	TodosShowWidget = 'chat.tools.todos.showWidget',
 	NotifyWindowOnResponseReceived = 'chat.notifyWindowOnResponseReceived',
 	ChatViewSessionsEnabled = 'chat.viewSessions.enabled',
+	ChatViewSessionsShowRecentOnly = 'chat.viewSessions.showRecentOnly',
 	ChatViewSessionsOrientation = 'chat.viewSessions.orientation',
 	ChatViewTitleEnabled = 'chat.viewTitle.enabled',
 	SubagentToolCustomAgents = 'chat.customAgentInSubagent.enabled',

Original file line number	Diff line number	Diff line change
`@@ -77,22 +77,6 @@`
`77`	`77`	`background-color: var(--vscode-inputOption-activeBackground);`
`78`	`78`	`}`
`79`	`79`	`}`
`80`		`-`
`81`		`- .agent-sessions-link-container {`
`82`		`- padding: 8px 0;`
`83`		`- font-size: 12px;`
`84`		`- text-align: center;`
`85`		`- }`
`86`		`-`
`87`		`- .agent-sessions-link-container a {`
`88`		`- color: var(--vscode-descriptionForeground);`
`89`		`- }`
`90`		`-`
`91`		`- .agent-sessions-link-container a:hover,`
`92`		`- .agent-sessions-link-container a:active {`
`93`		`- text-decoration: none;`
`94`		`- color: var(--vscode-textLink-foreground);`
`95`		`- }`
`96`	`80`	`}`
`97`	`81`
`98`	`82`	`/* Sessions control: stacked */`
`@@ -121,11 +105,6 @@`
`121`	`105`	`border-left: 1px solid var(--vscode-panel-border);`
`122`	`106`	`}`
`123`	`107`	`}`
`124`		`-`
`125`		`- .agent-sessions-link-container {`
`126`		`- /* hide link to show more when side by side */`
`127`		`- display: none;`
`128`		`- }`
`129`	`108`	`}`
`130`	`109`
`131`	`110`	`/*`