Fix conditional for sort by label (#260653)

TylerLeonhardt · web-flow · commit 87eebd9325e6 · 2025-08-08T19:51:56.000Z
ref #260619 (comment)
diff --git a/src/vs/platform/quickinput/browser/quickInputController.ts b/src/vs/platform/quickinput/browser/quickInputController.ts
@@ -546,7 +546,7 @@ export class QuickInputController extends Disposable {
 			input.ignoreFocusOut = !!options.ignoreFocusLost;
 			input.matchOnDescription = !!options.matchOnDescription;
 			input.matchOnDetail = !!options.matchOnDetail;
-			if (options.sortByLabel) {
+			if (options.sortByLabel !== undefined) {
 				input.sortByLabel = options.sortByLabel;
 			}
 			input.matchOnLabel = (options.matchOnLabel === undefined) || options.matchOnLabel; // default to true

Original file line number	Diff line number	Diff line change
`@@ -546,7 +546,7 @@ export class QuickInputController extends Disposable {`
`546`	`546`	`input.ignoreFocusOut = !!options.ignoreFocusLost;`
`547`	`547`	`input.matchOnDescription = !!options.matchOnDescription;`
`548`	`548`	`input.matchOnDetail = !!options.matchOnDetail;`
`549`		`- if (options.sortByLabel) {`
	`549`	`+ if (options.sortByLabel !== undefined) {`
`550`	`550`	`input.sortByLabel = options.sortByLabel;`
`551`	`551`	`}`
`552`	`552`	`input.matchOnLabel = (options.matchOnLabel === undefined) \|\| options.matchOnLabel; // default to true`