Skip to content

Commit 8b2ee1b

Browse files
committed
add comment why sync state should be scoped
1 parent d40b898 commit 8b2ee1b

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/vs/workbench/services/environment/browser/environmentService.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,11 @@ export class BrowserWorkbenchEnvironmentService implements IWorkbenchEnvironment
114114
@memoize
115115
get snippetsHome(): URI { return joinPath(this.userRoamingDataHome, 'snippets'); }
116116

117+
/*
118+
* In Web every workspace can potentially have scoped user-data and/or extensions and if Sync state is shared then it can make
119+
* Sync error prone - say removing extensions from another workspace. Hence scope Sync state per workspace.
120+
* Sync scoped to a workspace is capable of handling even if workspaces/windows share same user data and extensions.
121+
*/
117122
@memoize
118123
get userDataSyncHome(): URI { return joinPath(this.userRoamingDataHome, 'sync', this.options.workspaceId); }
119124

0 commit comments

Comments
 (0)