auto save - skip non-dirty editors (#200468)

Author: bpasero

src/vs/workbench/browser/parts/editor/editorAutoSave.ts

@@ -92,7 +92,11 @@ export class EditorAutoSave extends Disposable implements IWorkbenchContribution
 
 	private maybeTriggerAutoSave(reason: SaveReason, editorIdentifier?: IEditorIdentifier): void {
 		if (editorIdentifier) {
-			if (editorIdentifier.editor.isReadonly() || editorIdentifier.editor.hasCapability(EditorInputCapabilities.Untitled)) {
+			if (
+				!editorIdentifier.editor.isDirty() ||
+				editorIdentifier.editor.isReadonly() ||
+				editorIdentifier.editor.hasCapability(EditorInputCapabilities.Untitled)
+			) {
 				return; // no auto save for readonly or untitled editors
 			}
 
@@ -170,15 +174,15 @@ export class EditorAutoSave extends Disposable implements IWorkbenchContribution
 	}
 
 	private scheduleAutoSave(workingCopy: IWorkingCopy): void {
+		if (workingCopy.capabilities & WorkingCopyCapabilities.Untitled) {
+			return; // we never auto save untitled working copies
+		}
+
 		const autoSaveAfterDelay = this.filesConfigurationService.getAutoSaveConfiguration(workingCopy.resource).autoSaveDelay;
 		if (typeof autoSaveAfterDelay !== 'number') {
 			return; // auto save after delay must be enabled
 		}
 
-		if (workingCopy.capabilities & WorkingCopyCapabilities.Untitled) {
-			return; // we never auto save untitled working copies
-		}
-
 		// Clear any running auto save operation
 		this.discardAutoSave(workingCopy);
 

src/vs/workbench/services/workingCopy/common/workingCopyBackupTracker.ts

@@ -229,9 +229,11 @@ export abstract class WorkingCopyBackupTracker extends Disposable {
 			return workingCopy.backupDelay; // respect working copy override
 		}
 
-		let autoSaveMode = this.filesConfigurationService.getAutoSaveMode(workingCopy.resource);
+		let autoSaveMode: AutoSaveMode;
 		if (workingCopy.capabilities & WorkingCopyCapabilities.Untitled) {
 			autoSaveMode = AutoSaveMode.OFF; // auto-save is never on for untitled working copies
+		} else {
+			autoSaveMode = this.filesConfigurationService.getAutoSaveMode(workingCopy.resource);
 		}
 
 		return WorkingCopyBackupTracker.DEFAULT_BACKUP_SCHEDULE_DELAYS[autoSaveMode];