Include provider timings in endoflife event (#260333)

Author: benibenj

src/vs/editor/common/languages.ts

@@ -990,6 +990,8 @@ export type LifetimeSummary = {
 	shownDuration: number;
 	shownDurationUncollapsed: number;
 	timeUntilShown: number | undefined;
+	timeUntilProviderRequest: number;
+	timeUntilProviderResponse: number;
 	editorType: string;
 	viewKind: string | undefined;
 	error: string | undefined;

src/vs/editor/contrib/inlineCompletions/browser/model/provideInlineCompletions.ts

@@ -87,12 +87,14 @@ export function provideInlineCompletions(
 			}
 
 			let result: InlineCompletions | null | undefined;
+			const providerStartTime = Date.now();
 			try {
 				result = await provider.provideInlineCompletions(model, position, contextWithUuid, cancellationTokenSource.token);
 			} catch (e) {
 				onUnexpectedExternalError(e);
 				return undefined;
 			}
+			const providerEndTime = Date.now();
 
 			if (!result) {
 				return undefined;
@@ -109,7 +111,7 @@ export function provideInlineCompletions(
 			}
 
 			for (const item of result.items) {
-				data.push(toInlineSuggestData(item, list, defaultReplaceRange, model, languageConfigurationService, contextWithUuid, requestInfo));
+				data.push(toInlineSuggestData(item, list, defaultReplaceRange, model, languageConfigurationService, contextWithUuid, requestInfo, { startTime: providerStartTime, endTime: providerEndTime }));
 			}
 
 			return list;
@@ -162,7 +164,8 @@ function toInlineSuggestData(
 	textModel: ITextModel,
 	languageConfigurationService: ILanguageConfigurationService | undefined,
 	context: InlineCompletionContext,
-	requestInfo: InlineSuggestRequestInfo
+	requestInfo: InlineSuggestRequestInfo,
+	providerRequestInfo: InlineSuggestProviderRequestInfo,
 ): InlineSuggestData {
 	let insertText: string;
 	let snippetInfo: SnippetInfo | undefined;
@@ -236,7 +239,8 @@ function toInlineSuggestData(
 		source,
 		context,
 		inlineCompletion.isInlineEdit ?? false,
-		requestInfo
+		requestInfo,
+		providerRequestInfo,
 	);
 }
 
@@ -249,6 +253,11 @@ export type InlineSuggestRequestInfo = {
 	typingIntervalCharacterCount: number;
 };
 
+export type InlineSuggestProviderRequestInfo = {
+	startTime: number;
+	endTime: number;
+};
+
 export type InlineSuggestViewData = {
 	editorType: InlineCompletionEditorType;
 	renderData?: InlineCompletionViewData;
@@ -283,6 +292,7 @@ export class InlineSuggestData {
 		public readonly isInlineEdit: boolean,
 
 		private readonly _requestInfo: InlineSuggestRequestInfo,
+		private readonly _providerRequestInfo: InlineSuggestProviderRequestInfo,
 	) {
 		this._viewData = { editorType: _requestInfo.editorType };
 	}
@@ -350,6 +360,8 @@ export class InlineSuggestData {
 				shownDurationUncollapsed: this._showUncollapsedDuration,
 				preceeded: this._isPreceeded,
 				timeUntilShown: this._timeUntilShown,
+				timeUntilProviderRequest: this._providerRequestInfo.startTime - this._requestInfo.startTime,
+				timeUntilProviderResponse: this._providerRequestInfo.endTime - this._requestInfo.startTime,
 				editorType: this._viewData.editorType,
 				languageId: this._requestInfo.languageId,
 				requestReason: this._requestInfo.reason,

src/vs/monaco.d.ts

@@ -7630,6 +7630,8 @@ declare namespace monaco.languages {
 		shownDuration: number;
 		shownDurationUncollapsed: number;
 		timeUntilShown: number | undefined;
+		timeUntilProviderRequest: number;
+		timeUntilProviderResponse: number;
 		editorType: string;
 		viewKind: string | undefined;
 		error: string | undefined;

src/vs/workbench/api/browser/mainThreadLanguageFeatures.ts

@@ -655,6 +655,8 @@ export class MainThreadLanguageFeatures extends Disposable implements MainThread
 					shownDuration: lifetimeSummary.shownDuration,
 					shownDurationUncollapsed: lifetimeSummary.shownDurationUncollapsed,
 					timeUntilShown: lifetimeSummary.timeUntilShown,
+					timeUntilProviderRequest: lifetimeSummary.timeUntilProviderRequest,
+					timeUntilProviderResponse: lifetimeSummary.timeUntilProviderResponse,
 					editorType: lifetimeSummary.editorType,
 					viewKind: lifetimeSummary.viewKind,
 					preceeded: lifetimeSummary.preceeded,
@@ -1311,6 +1313,8 @@ type InlineCompletionEndOfLifeEvent = {
 	shownDuration: number;
 	shownDurationUncollapsed: number;
 	timeUntilShown: number | undefined;
+	timeUntilProviderRequest: number;
+	timeUntilProviderResponse: number;
 	reason: 'accepted' | 'rejected' | 'ignored';
 	partiallyAccepted: number;
 	preceeded: boolean;
@@ -1342,6 +1346,8 @@ type InlineCompletionsEndOfLifeClassification = {
 	shownDuration: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The duration for which the inline completion was shown' };
 	shownDurationUncollapsed: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The duration for which the inline completion was shown without collapsing' };
 	timeUntilShown: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The time it took for the inline completion to be shown after the request' };
+	timeUntilProviderRequest: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The time it took for the inline completion to be requested from the provider' };
+	timeUntilProviderResponse: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The time it took for the inline completion to be shown after the request' };
 	reason: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The reason for the inline completion ending' };
 	partiallyAccepted: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'How often the inline completion was partially accepted by the user' };
 	preceeded: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'Whether the inline completion was preceeded by another one' };