Skip to content

Commit cb9445f

Browse files
authored
Merge pull request #245235 from microsoft/robo/revert_244910_1_99
Revert "chore: pass webviewID with initial version message to sw"
2 parents d816496 + 9536c77 commit cb9445f

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

src/vs/workbench/contrib/webview/browser/pre/index-no-csp.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@
230230
return reject(new Error('Service Workers are not enabled. Webviews will not work. Try disabling private/incognito mode.'));
231231
}
232232

233-
const swPath = encodeURI(`service-worker.js?v=${expectedWorkerVersion}&vscode-resource-base-authority=${searchParams.get('vscode-resource-base-authority')}&remoteAuthority=${searchParams.get('remoteAuthority') ?? ''}`);
233+
const swPath = encodeURI(`service-worker.js?v=${expectedWorkerVersion}&vscode-resource-base-authority=${searchParams.get('vscode-resource-base-authority')}&id=${ID}&remoteAuthority=${searchParams.get('remoteAuthority') ?? ''}`);
234234
navigator.serviceWorker.register(swPath)
235235
.then(async registration => {
236236
/**
@@ -259,7 +259,7 @@
259259
navigator.serviceWorker.addEventListener('message', versionHandler);
260260

261261
const postVersionMessage = (/** @type {ServiceWorker} */ controller) => {
262-
controller.postMessage({ channel: 'version', data: { webviewID: ID } });
262+
controller.postMessage({ channel: 'version' });
263263
};
264264

265265
// At this point, either the service worker is ready and

src/vs/workbench/contrib/webview/browser/pre/index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<meta charset="UTF-8">
66

77
<meta http-equiv="Content-Security-Policy"
8-
content="default-src 'none'; script-src 'sha256-D+d2/k0hwjyCxorvVPVFGz3TsCJaNh2jVdTq7X+RsTU=' 'self'; frame-src 'self'; style-src 'unsafe-inline';">
8+
content="default-src 'none'; script-src 'sha256-nlLyDpnjtftJG2xvXh2vuy77l7xFTjfOz7Jnj1iXNmA=' 'self'; frame-src 'self'; style-src 'unsafe-inline';">
99

1010

1111
<!-- Disable pinch zooming -->
@@ -236,7 +236,7 @@
236236
return reject(new Error('Service Workers are not enabled. Webviews will not work. Try disabling private/incognito mode.'));
237237
}
238238

239-
const swPath = encodeURI(`service-worker.js?v=${expectedWorkerVersion}&vscode-resource-base-authority=${searchParams.get('vscode-resource-base-authority')}&remoteAuthority=${searchParams.get('remoteAuthority') ?? ''}`);
239+
const swPath = encodeURI(`service-worker.js?v=${expectedWorkerVersion}&vscode-resource-base-authority=${searchParams.get('vscode-resource-base-authority')}&id=${ID}&remoteAuthority=${searchParams.get('remoteAuthority') ?? ''}`);
240240
navigator.serviceWorker.register(swPath)
241241
.then(async registration => {
242242
/**
@@ -265,7 +265,7 @@
265265
navigator.serviceWorker.addEventListener('message', versionHandler);
266266

267267
const postVersionMessage = (/** @type {ServiceWorker} */ controller) => {
268-
controller.postMessage({ channel: 'version', data: { webviewID: ID } });
268+
controller.postMessage({ channel: 'version' });
269269
};
270270

271271
// At this point, either the service worker is ready and

src/vs/workbench/contrib/webview/browser/pre/service-worker.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ const searchParams = new URL(location.toString()).searchParams;
1818

1919
const remoteAuthority = searchParams.get('remoteAuthority');
2020

21-
let ID = '';
21+
const ID = searchParams.get('id');
2222

2323
/**
2424
* Origin used for resources
@@ -135,7 +135,6 @@ sw.addEventListener('message', async (event) => {
135135
switch (event.data.channel) {
136136
case 'version': {
137137
const source = /** @type {Client} */ (event.source);
138-
ID = event.data.webviewID;
139138
sw.clients.get(source.id).then(client => {
140139
if (client) {
141140
client.postMessage({

0 commit comments

Comments
 (0)