Don't restart EH when a chat request is in progress (#260674)

Fix #245215

Author: roblourens

src/vs/workbench/contrib/chat/common/chatContextKeys.ts

@@ -62,6 +62,7 @@ export namespace ChatContextKeys {
 	export const remoteJobCreating = new RawContextKey<boolean>('chatRemoteJobCreating', false, { type: 'boolean', description: localize('chatRemoteJobCreating', "True when a remote coding agent job is being created.") });
 	export const hasRemoteCodingAgent = new RawContextKey<boolean>('hasRemoteCodingAgent', false, localize('hasRemoteCodingAgent', "Whether any remote coding agent is available"));
 	export const enableRemoteCodingAgentPromptFileOverlay = new RawContextKey<boolean>('enableRemoteCodingAgentPromptFileOverlay', false, localize('enableRemoteCodingAgentPromptFileOverlay', "Whether the remote coding agent prompt file overlay feature is enabled"));
+	/** Used by the extension to skip the quit confirmation when #new wants to open a new folder */
 	export const skipChatRequestInProgressMessage = new RawContextKey<boolean>('chatSkipRequestInProgressMessage', false, { type: 'boolean', description: localize('chatSkipRequestInProgressMessage', "True when the chat request in progress message should be skipped.") });
 
 	export const Setup = {

src/vs/workbench/contrib/chat/electron-browser/chat.contribution.ts

@@ -33,6 +33,7 @@ import { autorun } from '../../../../base/common/observable.js';
 import { ILifecycleService, ShutdownReason } from '../../../services/lifecycle/common/lifecycle.js';
 import { IDialogService } from '../../../../platform/dialogs/common/dialogs.js';
 import { isMacintosh } from '../../../../base/common/platform.js';
+import { IExtensionService } from '../../../services/extensions/common/extensions.js';
 
 class NativeBuiltinToolsContribution extends Disposable implements IWorkbenchContribution {
 
@@ -142,13 +143,18 @@ class ChatLifecycleHandler extends Disposable {
 		@IChatService private readonly chatService: IChatService,
 		@IDialogService private readonly dialogService: IDialogService,
 		@IViewsService private readonly viewsService: IViewsService,
-		@IContextKeyService private readonly contextKeyService: IContextKeyService
+		@IContextKeyService private readonly contextKeyService: IContextKeyService,
+		@IExtensionService extensionService: IExtensionService,
 	) {
 		super();
 
 		this._register(lifecycleService.onBeforeShutdown(e => {
 			e.veto(this.shouldVetoShutdown(e.reason), 'veto.chat');
 		}));
+
+		this._register(extensionService.onWillStop(e => {
+			e.veto(this.chatService.requestInProgressObs.get(), localize('chatRequestInProgress', "A chat request is in progress."));
+		}));
 	}
 
 	private shouldVetoShutdown(reason: ShutdownReason): boolean | Promise<boolean> {