debug: only store dynamic configs in memory

isidorn · isidorn · commit ccb5438c877c · 2020-06-17T12:51:21.000+02:00
diff --git a/src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts b/src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts
@@ -480,9 +480,10 @@ export class ConfigurationManager implements IConfigurationManager {
 			this.setSelectedLaunchName(names.length ? names[0] : undefined);
 		}
 
-		this.selectedConfig = config || (this.selectedLaunch && this.selectedName ? this.selectedLaunch.getConfiguration(this.selectedName) : undefined);
-		if (this.selectedConfig) {
-			this.debugConfigurationTypeContext.set(this.selectedConfig.type);
+		this.selectedConfig = config;
+		const configForType = this.selectedConfig || (this.selectedLaunch && this.selectedName ? this.selectedLaunch.getConfiguration(this.selectedName) : undefined);
+		if (configForType) {
+			this.debugConfigurationTypeContext.set(configForType.type);
 		} else {
 			this.debugConfigurationTypeContext.reset();
 		}

Original file line number	Diff line number	Diff line change
`@@ -480,9 +480,10 @@ export class ConfigurationManager implements IConfigurationManager {`
`480`	`480`	`this.setSelectedLaunchName(names.length ? names[0] : undefined);`
`481`	`481`	`}`
`482`	`482`
`483`		`- this.selectedConfig = config \|\| (this.selectedLaunch && this.selectedName ? this.selectedLaunch.getConfiguration(this.selectedName) : undefined);`
`484`		`- if (this.selectedConfig) {`
`485`		`- this.debugConfigurationTypeContext.set(this.selectedConfig.type);`
	`483`	`+ this.selectedConfig = config;`
	`484`	`+ const configForType = this.selectedConfig \|\| (this.selectedLaunch && this.selectedName ? this.selectedLaunch.getConfiguration(this.selectedName) : undefined);`
	`485`	`+ if (configForType) {`
	`486`	`+ this.debugConfigurationTypeContext.set(configForType.type);`
`486`	`487`	`} else {`
`487`	`488`	`this.debugConfigurationTypeContext.reset();`
`488`	`489`	`}`