Skip to content

Commit e120edc

Browse files
committed
chore: remove stale TODOs about lifecycle hack
1 parent dcd097c commit e120edc

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/vs/workbench/contrib/terminal/browser/terminalTabbedView.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -592,10 +592,8 @@ export class TerminalTabbedView extends Disposable {
592592
// be focused. So wait for connection to finish, then focus.
593593
const previousActiveElement = this._tabListElement.ownerDocument.activeElement;
594594
if (previousActiveElement) {
595-
// TODO: Improve lifecycle management this event should be disposed after first fire
596595
const listener = this._register(Event.once(this._terminalService.onDidChangeConnectionState)(() => {
597596
// Only focus the terminal if the activeElement has not changed since focus() was called
598-
// TODO: Hack
599597
if (dom.isActiveElement(previousActiveElement)) {
600598
this._focus();
601599
}

0 commit comments

Comments
 (0)