mcp: fix only keeping 1 MCP server per config file (#254522)

connor4312 · web-flow · commit f57b94f25514 · 2025-07-08T14:07:59.000+02:00
Fixes #254498
diff --git a/src/vs/workbench/contrib/mcp/browser/mcpWorkbenchService.ts b/src/vs/workbench/contrib/mcp/browser/mcpWorkbenchService.ts
@@ -216,7 +216,7 @@ export class McpWorkbenchService extends Disposable implements IMcpWorkbenchServ
 		} else {
 			server = this.instantiationService.createInstance(McpWorkbenchServer, e => this.getInstallState(e), local, gallery, undefined);
 		}
-		this._local = this._local.filter(e => e.name === local.name);
+		this._local = this._local.filter(e => e.name !== local.name);
 		this._local.push(server);
 		this._onChange.fire(server);
 		return server;

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ export class McpWorkbenchService extends Disposable implements IMcpWorkbenchServ`
`216`	`216`	`} else {`
`217`	`217`	`server = this.instantiationService.createInstance(McpWorkbenchServer, e => this.getInstallState(e), local, gallery, undefined);`
`218`	`218`	`}`
`219`		`- this._local = this._local.filter(e => e.name === local.name);`
	`219`	`+ this._local = this._local.filter(e => e.name !== local.name);`
`220`	`220`	`this._local.push(server);`
`221`	`221`	`this._onChange.fire(server);`
`222`	`222`	`return server;`