-
Notifications
You must be signed in to change notification settings - Fork 34.9k
Open
Labels
engineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.
Milestone
Description
As part of #252068 and soon to prepare for npm/cli#8153 we want to move the native module dependencies from the root package.json. But this is also a good time to revisit how our dependencies are shared, today there is a dupe of dependency declarations across remote, web and root. Could we restructure in a way that there is no longer dependencies on the root but something like
vscode
|
|-> shared
|-> package.json (dependencies shared across sub folders and possibly common napi native modules)
|-> electron
|-> package.json
|-> .npmrc
|-> remote
|-> package.json
|-> .npmrc
|-> web
|-> package.json
|-> .npmrc
This could pave option for users building only web target of vscode doesn't have to build the entire module tree of the client.
/cc @bpasero @joaomoreno
Metadata
Metadata
Assignees
Labels
engineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.