-
Notifications
You must be signed in to change notification settings - Fork 34.3k
Open
Labels
debtCode quality issuesCode quality issuesengineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.help wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunities
Description
- source files are duplicated inside sourcemap
❯ npm run gulp compile-build-without-mangling
❯ cat out-build/main.js.map | jq .sourceRoot
"file:///Users/tmm1/code/vscode/src"
❯ cat out-build/main.js.map | jq .sources
[
"file:///Users/tmm1/code/vscode/src/main.ts",
"main.ts"
]
- duplicated paths are further corrupted during minification
❯ npm run gulp minify-vscode
❯ cat out-vscode/main.js.map | jq '.sources[0,1]'
"../file:/Users/tmm1/code/vscode/src/vs/base/common/performance.ts"
"../vs/base/common/performance.ts"
❯ cat out-vscode-min/main.js.map | jq '.sources[0,1]'
"./file:/Users/tmm1/code/vscode/src/vs/base/common/performance.ts"
"vs/base/common/performance.ts"
Metadata
Metadata
Labels
debtCode quality issuesCode quality issuesengineeringVS Code - Build / issue tracking / etc.VS Code - Build / issue tracking / etc.help wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunities