Skip to content

Avoid declaring variables and includes in terminal suggest compare fn #250696

New issue
New issue
Closed
#260640
Closed
Avoid declaring variables and includes in terminal suggest compare fn#250696
#260640
Assignees
anthonykim1
Labels
perfterminal-suggestunreleasedPatch has not yet been released in VS Code Insiders
Milestone
August 2025
@Tyriar

Description

@Tyriar
Tyriar
opened on Jun 4, 2025

We should avoid variables here to help the JIT optimize this very hot function:

vscode/src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionModel.ts

Lines 29 to 32 in 340c1bb

// Boost LSP provider completions
const lspProviderId = 'python';
const aIsLsp = a.completion.provider.includes(lspProviderId);
const bIsLsp = b.completion.provider.includes(lspProviderId);

Also includes may be wasteful, can this just be a === check instead?

Metadata

Metadata

Assignees

Labels

perfterminal-suggestunreleasedPatch has not yet been released in VS Code Insiders

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions