-
Notifications
You must be signed in to change notification settings - Fork 34.9k
Description
Had issues syncing vscode sources into the chat extension (see https://github.com/microsoft/vscode-copilot-chat/blob/main/CONTRIBUTING.md#use-basecommon-utils) due to a difference in base .d.ts between the two.
PR microsoft/vscode-copilot-chat#518
The typecheck script failed with errors like this Error: src/util/vs/base/common/async.ts(520,3): error TS2741: Property '_' is missing in type 'Timeout' but required in type 'TimeoutHandle'.
https://github.com/microsoft/vscode-copilot-chat/actions/runs/16837700919/job/47701113942#step:10:15
If I just run the npx tsc --noEmit --project test/simulation/workbench/tsconfig.json
part, it fails, but if I run npx tsc --noEmit --project tsconfig.json
it doesn't fail. I made this commit microsoft/vscode-copilot-chat@45f35b0 to work around it. I can't figure out why this is happening but it seems like the simulation workbench build just doesn't see the base-common.d.ts
overload of setTimeout
. When that error says Timeout
it's referring to NodeJS.Timeout
, not the Timeout
type in that file. Any ideas @bpasero?
If you want to try it yourself, you can check out that PR, just make sure you either get the commit before microsoft/vscode-copilot-chat@45f35b0 or revert that change. Then run npm run typecheck
.