-
Notifications
You must be signed in to change notification settings - Fork 35.1k
Description
I had issues syncing vscode sources into the chat extension (see https://github.com/microsoft/vscode-copilot-chat/blob/main/CONTRIBUTING.md#use-basecommon-utils) due to some differences in the core/edits files.
The PR is at microsoft/vscode-copilot-chat#518. I made some manual edits here
- microsoft/vscode-copilot-chat@4b82e6b to avoid some type errors that I couldn't figure out how to resolve
- microsoft/vscode-copilot-chat@2108e21 to hook up this
ensureDependenciesAreSet
function
Then after that, I still have some vitest failures, I think because there used to be a JSON.stringify
here https://github.com/microsoft/vscode-copilot-chat/blob/2108e213b9019dcb9616ae16e93763e31d30f478/src/util/vs/editor/common/core/edits/stringEdit.ts#L204.
Could you look at these? I'm also not sure what other manual changes might have been made that might be missing but not causing build or test failures. I'd really like to get back to a place where we can do a clean run of copySources.ts
to keep things in sync.
(I also am working through this issue #260650, there are currently more manual edits in the PR branch for that)