Disappearing terminal confirmation editors

[roblourens]

• get a terminal tool confirmation
• click into it
• It disappears

This is weird- what happened is that the editor's model was disposed, and the editor was removed from the DOM. That happened when the wordHighlighter contrib disposed its reference and there were no remaining refs. I don't know what changed, and I can't repro reliably.

I'm a little unsure about the proper flow, I think we are using createModel wrong somehow.

vscode/src/vs/workbench/contrib/chat/browser/chatContentParts/toolInvocationParts/chatTerminalToolSubPart.ts

Lines 118 to 123 in 7ca850c

	const model = this.modelService.createModel(
	terminalData.commandLine.toolEdited ?? terminalData.commandLine.original,
	this.languageService.createById(langId),
	this._getUniqueCodeBlockUri(),
	true
	);

In some places like

vscode/src/vs/workbench/contrib/bulkEdit/browser/preview/bulkEditPreview.ts

Lines 443 to 448 in 7ca850c

	// this is a little weird but otherwise editors and other cusomers
	// will dispose my models before they should be disposed...
	// And all of this is off the eventloop to prevent endless recursion
	queueMicrotask(async () => {
	this._disposables.add(await this._textModelResolverService.createModelReference(model!.uri));
	});

I see them call createModelReference after createModel, maybe we are supposed to do that.

@Tyriar you've touched this code recently, any idea? I haven't tried to bisect yet.

[Tyriar]

This is happening because of the following line:

vscode/src/vs/editor/contrib/wordHighlighter/browser/wordHighlighter.ts

Line 719 in 7ca850c

queryModelRef.dispose();

It was added in 0c939e4

@Yoyokrazy that was a challenge figuring out where it was happening. I'm going to disable WordHighlighterContribution.ID in CodeBlockPart as a workaround in my upcoming PR. We need to understand what's going on here

[Tyriar]

Actually figured it out, you're right @roblourens we need to call that reference call to make sure it doesn't get disposed. Will fix soon, FYI this has been happening for a very long time at this point but couldn't figure out the repro.