Revert usage of bang bang annotation (#3691)

Author: Evangelink

.editorconfig

@@ -198,7 +198,7 @@ dotnet_diagnostic.CA1834.severity = warning # not default, increased severity to
 
 # IDE0190: Null check can be simplified
 # Keep this in sync with the related C# rule: csharp_style_prefer_parameter_null_checking
-dotnet_diagnostic.IDE0190.severity = warning # not default, increased severity to ensure it is applied
+dotnet_diagnostic.IDE0190.severity = silent # not default, disabled as feature is no longer supported
 
 # CA1840: Use 'Environment.CurrentManagedThreadId'
 dotnet_diagnostic.CA1840.severity = warning # not default, increased severity to ensure it is applied
@@ -264,7 +264,7 @@ csharp_using_directive_placement = outside_namespace:warning
 
 # IDE0190: Null check can be simplified
 # Keep this in sync with the related .NET rule: IDE0190
-csharp_style_prefer_parameter_null_checking = true # not default, increased severity to ensure it is applied
+csharp_style_prefer_parameter_null_checking = false # not default, disabled as no longer supported
 
 #### .NET Formatting Rules ####
 

src/AttachVS/Program.cs

@@ -9,8 +9,10 @@ namespace Microsoft.TestPlatform.AttachVS;
 
 internal class Program
 {
-    static void Main(string[] args!!)
+    static void Main(string[] args)
     {
+        _ = args ?? throw new ArgumentNullException(nameof(args));
+
         Trace.Listeners.Add(new ConsoleTraceListener());
 
         int? pid = ParsePid(args, position: 0);

src/DataCollectors/Microsoft.TestPlatform.Extensions.EventLogCollector/EventLogDataCollector.cs

@@ -151,11 +151,16 @@ internal EventLogDataCollector(IFileHelper fileHelper)
     [MemberNotNull(nameof(_events), nameof(_dataSink), nameof(_logger))]
     public override void Initialize(
         XmlElement? configurationElement,
-        DataCollectionEvents events!!,
-        DataCollectionSink dataSink!!,
-        DataCollectionLogger logger!!,
-        DataCollectionEnvironmentContext dataCollectionEnvironmentContext!!)
+        DataCollectionEvents events,
+        DataCollectionSink dataSink,
+        DataCollectionLogger logger,
+        DataCollectionEnvironmentContext dataCollectionEnvironmentContext)
     {
+        ValidateArg.NotNull(events, nameof(events));
+        ValidateArg.NotNull(dataSink, nameof(dataSink));
+        ValidateArg.NotNull(logger, nameof(logger));
+        ValidateArg.NotNull(dataCollectionEnvironmentContext, nameof(dataCollectionEnvironmentContext));
+
         _events = events;
         _dataSink = dataSink;
         _logger = logger;
@@ -320,26 +325,29 @@ private static ISet<string> ParseCommaSeparatedList(string commaSeparatedList)
         return strings;
     }
 
-    private void OnSessionStart(object sender, SessionStartEventArgs e!!)
+    private void OnSessionStart(object sender, SessionStartEventArgs e)
     {
+        ValidateArg.NotNull(e, nameof(e));
         ValidateArg.NotNull(e.Context, "SessionStartEventArgs.Context");
 
         EqtTrace.Verbose("EventLogDataCollector: SessionStart received");
 
         StartCollectionForContext(e.Context);
     }
 
-    private void OnSessionEnd(object sender, SessionEndEventArgs e!!)
+    private void OnSessionEnd(object sender, SessionEndEventArgs e)
     {
+        ValidateArg.NotNull(e, nameof(e));
         ValidateArg.NotNull(e.Context, "SessionEndEventArgs.Context");
 
         EqtTrace.Verbose("EventLogDataCollector: SessionEnd received");
 
         WriteCollectedEventLogEntries(e.Context, true, TimeSpan.MaxValue, DateTime.UtcNow);
     }
 
-    private void OnTestCaseStart(object sender, TestCaseStartEventArgs e!!)
+    private void OnTestCaseStart(object sender, TestCaseStartEventArgs e)
     {
+        ValidateArg.NotNull(e, nameof(e));
         ValidateArg.NotNull(e.Context, "TestCaseStartEventArgs.Context");
 
         if (!e.Context.HasTestCase)
@@ -353,8 +361,9 @@ private void OnTestCaseStart(object sender, TestCaseStartEventArgs e!!)
         StartCollectionForContext(e.Context);
     }
 
-    private void OnTestCaseEnd(object sender, TestCaseEndEventArgs e!!)
+    private void OnTestCaseEnd(object sender, TestCaseEndEventArgs e)
     {
+        ValidateArg.NotNull(e, nameof(e));
         TPDebug.Assert(e.Context != null, "Context is null");
         TPDebug.Assert(e.Context.HasTestCase, "Context is not for a test case");
 

src/Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameHelper.Reflection.cs

@@ -80,8 +80,10 @@ public static void GetManagedName(MethodBase method, out string managedTypeName,
     /// More information about <paramref name="managedTypeName"/> and <paramref name="managedMethodName"/> can be found in
     /// <see href="https://github.com/microsoft/vstest-docs/blob/main/RFCs/0017-Managed-TestCase-Properties.md">the RFC</see>.
     /// </remarks>
-    public static void GetManagedName(MethodBase method!!, out string managedTypeName, out string managedMethodName, out string[] hierarchyValues)
+    public static void GetManagedName(MethodBase method, out string managedTypeName, out string managedMethodName, out string[] hierarchyValues)
     {
+        _ = method ?? throw new ArgumentNullException(nameof(method));
+
         if (!ReflectionHelpers.IsMethod(method))
         {
             // TODO: @Haplois, exception expects a message and not a param name.

src/Microsoft.TestPlatform.Client/Execution/TestRunRequest.cs

@@ -355,8 +355,10 @@ public void Dispose()
     /// <summary>
     /// Invoked when test run is complete
     /// </summary>
-    public void HandleTestRunComplete(TestRunCompleteEventArgs runCompleteArgs!!, TestRunChangedEventArgs lastChunkArgs, ICollection<AttachmentSet> runContextAttachments, ICollection<string> executorUris)
+    public void HandleTestRunComplete(TestRunCompleteEventArgs runCompleteArgs, TestRunChangedEventArgs lastChunkArgs, ICollection<AttachmentSet> runContextAttachments, ICollection<string> executorUris)
     {
+        ValidateArg.NotNull(runCompleteArgs, nameof(runCompleteArgs));
+
         bool isAborted = runCompleteArgs.IsAborted;
         bool isCanceled = runCompleteArgs.IsCanceled;
 

src/Microsoft.TestPlatform.Client/TestPlatform.cs

@@ -7,6 +7,7 @@
 using System.IO;
 using System.Linq;
 using System.Reflection;
+using System.Xml;
 
 using Microsoft.VisualStudio.TestPlatform.Client.Discovery;
 using Microsoft.VisualStudio.TestPlatform.Client.Execution;
@@ -80,10 +81,12 @@ protected internal TestPlatform(
     /// <inheritdoc/>
     public IDiscoveryRequest CreateDiscoveryRequest(
         IRequestData requestData,
-        DiscoveryCriteria discoveryCriteria!!,
+        DiscoveryCriteria discoveryCriteria,
         TestPlatformOptions options,
         Dictionary<string, SourceDetail> sourceToSourceDetailMap)
     {
+        ValidateArg.NotNull(discoveryCriteria, nameof(discoveryCriteria));
+
         PopulateExtensions(discoveryCriteria.RunSettings, discoveryCriteria.Sources);
 
         // Initialize loggers.
@@ -99,10 +102,12 @@ public IDiscoveryRequest CreateDiscoveryRequest(
     /// <inheritdoc/>
     public ITestRunRequest CreateTestRunRequest(
         IRequestData requestData,
-        TestRunCriteria testRunCriteria!!,
+        TestRunCriteria testRunCriteria,
         TestPlatformOptions options,
         Dictionary<string, SourceDetail> sourceToSourceDetailMap)
     {
+        ValidateArg.NotNull(testRunCriteria, nameof(testRunCriteria));
+
         IEnumerable<string> sources = GetSources(testRunCriteria);
         PopulateExtensions(testRunCriteria.TestRunSettings, sources);
 
@@ -119,10 +124,12 @@ public ITestRunRequest CreateTestRunRequest(
     /// <inheritdoc/>
     public bool StartTestSession(
         IRequestData requestData,
-        StartTestSessionCriteria testSessionCriteria!!,
+        StartTestSessionCriteria testSessionCriteria,
         ITestSessionEventsHandler eventsHandler,
         Dictionary<string, SourceDetail> sourceToSourceDetailMap)
     {
+        ValidateArg.NotNull(testSessionCriteria, nameof(testSessionCriteria));
+
         RunConfiguration runConfiguration = XmlRunSettingsUtilities.GetRunConfigurationNode(testSessionCriteria.RunSettings);
         TestAdapterLoadingStrategy strategy = runConfiguration.TestAdapterLoadingStrategy;
 
@@ -359,7 +366,7 @@ private static IEnumerable<string> ExpandAdaptersWithExplicitStrategy(string pat
 
     private static IEnumerable<string> ExpandAdaptersWithDefaultStrategy(string path, IFileHelper fileHelper)
     {
-        // This is the legacy behavior, please do not modify this method unless you're sure of 
+        // This is the legacy behavior, please do not modify this method unless you're sure of
         // side effect when running tests with legacy adapters.
         if (!fileHelper.DirectoryExists(path))
         {

src/Microsoft.TestPlatform.Common/DataCollection/DataCollectionAttachmentManager.cs

@@ -98,8 +98,11 @@ internal ConcurrentDictionary<DataCollectionContext, ConcurrentDictionary<Uri, A
         get; private set;
     }
     /// <inheritdoc/>
-    public void Initialize(SessionId id!!, string outputDirectory, IMessageSink messageSink!!)
+    public void Initialize(SessionId id, string outputDirectory, IMessageSink messageSink)
     {
+        ValidateArg.NotNull(id, nameof(id));
+        ValidateArg.NotNull(messageSink, nameof(messageSink));
+
         _messageSink = messageSink;
 
         if (outputDirectory.IsNullOrEmpty())
@@ -159,8 +162,10 @@ public List<AttachmentSet> GetAttachments(DataCollectionContext dataCollectionCo
     }
 
     /// <inheritdoc/>
-    public void AddAttachment(FileTransferInformation fileTransferInfo!!, AsyncCompletedEventHandler sendFileCompletedCallback, Uri uri, string friendlyName)
+    public void AddAttachment(FileTransferInformation fileTransferInfo, AsyncCompletedEventHandler sendFileCompletedCallback, Uri uri, string friendlyName)
     {
+        ValidateArg.NotNull(fileTransferInfo, nameof(fileTransferInfo));
+
         if (SessionOutputDirectory.IsNullOrEmpty())
         {
             EqtTrace.Error("DataCollectionAttachmentManager.AddAttachment: Initialize not invoked.");

src/Microsoft.TestPlatform.Common/DataCollection/DataCollectionManager.cs

@@ -154,11 +154,12 @@ public static DataCollectionManager Create(IMessageSink messageSink, IRequestDat
     }
 
     /// <inheritdoc/>
-    public IDictionary<string, string> InitializeDataCollectors(string settingsXml!!)
+    public IDictionary<string, string> InitializeDataCollectors(string settingsXml)
     {
+        ValidateArg.NotNull(settingsXml, nameof(settingsXml));
         if (settingsXml.IsNullOrEmpty())
         {
-            EqtTrace.Info("DataCollectionManager.InitializeDataCollectors : Runsettings is null or empty.");
+            EqtTrace.Info("DataCollectionManager.InitializeDataCollectors: Runsettings is null or empty.");
         }
 
         var sessionId = new SessionId(Guid.NewGuid());
@@ -585,8 +586,9 @@ private void LogWarning(string warningMessage)
     /// know when all plugins have completed processing the event
     /// </summary>
     /// <param name="args">The context information for the event</param>
-    private void SendEvent(DataCollectionEventArgs args!!)
+    private void SendEvent(DataCollectionEventArgs args)
     {
+        ValidateArg.NotNull(args, nameof(args));
         if (!_isDataCollectionEnabled)
         {
             EqtTrace.Error("DataCollectionManger:SendEvent: SendEvent called when no collection is enabled.");

src/Microsoft.TestPlatform.Common/DataCollection/DataCollectorConfig.cs

@@ -24,10 +24,10 @@ internal class DataCollectorConfig : TestExtensionPluginInformation
     /// <param name="type">
     /// The type.
     /// </param>
-    public DataCollectorConfig(Type type!!)
+    public DataCollectorConfig(Type type)
         : base(type)
     {
-        DataCollectorType = type;
+        DataCollectorType = type ?? throw new ArgumentNullException(nameof(type));
         TypeUri = GetTypeUri(type);
         FriendlyName = GetFriendlyName(type);
         AttachmentsProcessorType = GetAttachmentsProcessors(type);

src/Microsoft.TestPlatform.Common/DataCollection/TestPlatformDataCollectionEvents.cs

@@ -77,8 +77,10 @@ internal TestPlatformDataCollectionEvents()
     /// <param name="e">
     /// Contains the event data
     /// </param>
-    internal void RaiseEvent(DataCollectionEventArgs e!!)
+    internal void RaiseEvent(DataCollectionEventArgs e)
     {
+        ValidateArg.NotNull(e, nameof(e));
+
         if (_eventArgsToEventInvokerMap.TryGetValue(e.GetType(), out var onEvent))
         {
             onEvent(e);