Code analysis with static analysers based on microsoft rules (#2831)

Code refactoring.

Author: HeroMaxPower

src/DataCollectors/Microsoft.TestPlatform.Extensions.EventLogCollector/EventLogDataCollector.cs

@@ -371,7 +371,6 @@ protected override void Dispose(bool disposing)
 
             // Delete all the temp event log directories
             this.RemoveTempEventLogDirs(this.eventLogDirectories);
-            GC.SuppressFinalize(this);
         }
 
         #endregion

src/Microsoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameHelper.Reflection.cs

@@ -24,12 +24,12 @@ public static partial class ManagedNameHelper
         /// A <see cref="MethodBase" /> instance to get fully qualified managed type and method name.
         /// </param>
         /// <param name="managedTypeName">
-        /// When this method returns, contains the fully qualified managed type name of the <paramref name="method"/>. 
+        /// When this method returns, contains the fully qualified managed type name of the <paramref name="method"/>.
         /// This parameter is passed uninitialized; any value originally supplied in result will be overwritten.
         /// The format is defined in <see href="https://github.com/microsoft/vstest-docs/blob/master/RFCs/0017-Managed-TestCase-Properties.md#managedtype-property">the RFC</see>.
         /// </param>
         /// <param name="managedMethodName">
-        /// When this method returns, contains the fully qualified managed method name of the <paramref name="method"/>. 
+        /// When this method returns, contains the fully qualified managed method name of the <paramref name="method"/>.
         /// This parameter is passed uninitialized; any value originally supplied in result will be overwritten.
         /// The format is defined in <see href="https://github.com/microsoft/vstest-docs/blob/master/RFCs/0017-Managed-TestCase-Properties.md#managedmethod-property">the RFC</see>.
         /// </param>
@@ -43,7 +43,7 @@ public static partial class ManagedNameHelper
         /// Required functionality on <paramref name="method"/> is missing on the current platform.
         /// </exception>
         /// <remarks>
-        /// More information about <paramref name="managedTypeName"/> and <paramref name="managedMethodName"/> can be found in 
+        /// More information about <paramref name="managedTypeName"/> and <paramref name="managedMethodName"/> can be found in
         /// <see href="https://github.com/microsoft/vstest-docs/blob/master/RFCs/0017-Managed-TestCase-Properties.md">the RFC</see>.
         /// </remarks>
         public static void GetManagedName(MethodBase method, out string managedTypeName, out string managedMethodName)
@@ -65,7 +65,7 @@ public static void GetManagedName(MethodBase method, out string managedTypeName,
                 // sure we are working with the open form of the generic type.
                 semanticType = semanticType.GetGenericTypeDefinition();
 
-                // The method might have some of its parameters specified by the original closed type 
+                // The method might have some of its parameters specified by the original closed type
                 // declaration. Here we use the method handle (basically metadata token) to create
                 // a new method reference using the open form of the reflected type. The intent is
                 // to strip all generic type parameters.
@@ -114,7 +114,7 @@ public static void GetManagedName(MethodBase method, out string managedTypeName,
         }
 
         /// <summary>
-        /// Gets the <see cref="MethodBase"/> object with the specified <paramref name="managedTypeName"/> 
+        /// Gets the <see cref="MethodBase"/> object with the specified <paramref name="managedTypeName"/>
         /// and <paramref name="managedMethodName"/> in the <paramref name="assembly"/> instance.
         /// </summary>
         /// <param name="assembly">
@@ -132,11 +132,11 @@ public static void GetManagedName(MethodBase method, out string managedTypeName,
         /// A <see cref="MethodBase" /> object that represents specified parameters, throws if null.
         /// </returns>
         /// <exception cref="InvalidManagedNameException">
-        /// Values specified with <paramref name="managedTypeName"/> and <paramref name="managedMethodName"/> 
+        /// Values specified with <paramref name="managedTypeName"/> and <paramref name="managedMethodName"/>
         /// does not correspond to a method in the <paramref name="assembly"/> instance, or malformed.
         /// </exception>
         /// <remarks>
-        /// More information about <paramref name="managedTypeName"/> and <paramref name="managedMethodName"/> can be found in 
+        /// More information about <paramref name="managedTypeName"/> and <paramref name="managedMethodName"/> can be found in
         /// <see href="https://github.com/microsoft/vstest-docs/blob/master/RFCs/0017-Managed-TestCase-Properties.md">the RFC</see>.
         /// </remarks>
         public static MethodBase GetMethod(Assembly assembly, string managedTypeName, string managedMethodName)
@@ -335,7 +335,7 @@ private static void AppendMethodString(StringBuilder methodBuilder, string name,
 
         private static void NormalizeAndAppendString(StringBuilder b, string name)
         {
-            b.Append("'");
+            b.Append('\'');
             for (int i = 0; i < name.Length; i++)
             {
                 char c = name[i];
@@ -348,15 +348,15 @@ private static void NormalizeAndAppendString(StringBuilder b, string name)
                         // b.Append('0', 4 - encoded.Length);
                         // b.Append(encoded);
 
-                        b.Append("\\");
+                        b.Append('\\');
                         b.Append(c);
                         continue;
                     }
                 }
 
                 b.Append(c);
             }
-            b.Append("'");
+            b.Append('\'');
         }
 
         private static int AppendNestedTypeName(StringBuilder b, Type type)
@@ -439,7 +439,7 @@ private static bool NeedsEscaping(char c, int pos)
             }
 
             if (c == '_'
-              || char.IsLetterOrDigit(c) // Lu, Ll, Lt, Lm, Lo, or Nl 
+              || char.IsLetterOrDigit(c) // Lu, Ll, Lt, Lm, Lo, or Nl
               )
             {
                 return false;

src/Microsoft.TestPlatform.Build/ArgumentEscaper.cs

@@ -23,7 +23,7 @@ public static string HandleEscapeSequenceInArgForProcessStart(string arg)
 
             if (needsQuotes)
             {
-                sb.Append("\"");
+                sb.Append('\"');
             }
 
             for (int i = 0; i < arg.Length; ++i)
@@ -70,7 +70,7 @@ public static string HandleEscapeSequenceInArgForProcessStart(string arg)
 
             if (needsQuotes)
             {
-                sb.Append("\"");
+                sb.Append('\"');
             }
 
             return sb.ToString();

src/Microsoft.TestPlatform.Client/Discovery/DiscoveryRequest.cs

@@ -267,7 +267,7 @@ public void HandleDiscoveryComplete(DiscoveryCompleteEventArgs discoveryComplete
                     // Raise onDiscoveredTests event if there are some tests in the last chunk.
                     // (We don't want to send the tests in the discovery complete event so that programming on top of
                     // RS client is easier i.e. user does not have to listen on discovery complete event.)
-                    if (lastChunk != null && lastChunk.Count() > 0)
+                    if (lastChunk != null && lastChunk.Any())
                     {
                         var discoveredTestsEvent = new DiscoveredTestsEventArgs(lastChunk);
                         this.LoggerManager.HandleDiscoveredTests(discoveredTestsEvent);

src/Microsoft.TestPlatform.Common/ExtensionFramework/TestPluginManager.cs

@@ -69,7 +69,7 @@ public static T CreateTestExtension<T>(Type extensionType)
         {
             if (extensionType == null)
             {
-                throw new ArgumentNullException("extensionType");
+                throw new ArgumentNullException(nameof(extensionType));
             }
 
             EqtTrace.Info("TestPluginManager.CreateTestExtension: Attempting to load test extension: " + extensionType);

src/Microsoft.TestPlatform.Common/Logging/InternalTestLoggerEvents.cs

@@ -177,7 +177,7 @@ internal void RaiseTestRunMessage(TestRunMessageEventArgs args)
         {
             if (args == null)
             {
-                throw new ArgumentNullException("args");
+                throw new ArgumentNullException(nameof(args));
             }
 
             this.CheckDisposed();

src/Microsoft.TestPlatform.Common/Logging/TestSessionMessageLogger.cs

@@ -64,7 +64,7 @@ public void SendMessage(TestMessageLevel testMessageLevel, string message)
         {
             if (string.IsNullOrWhiteSpace(message))
             {
-                throw new ArgumentException(ObjectModelCommonResources.CannotBeNullOrEmpty, "message");
+                throw new ArgumentException(ObjectModelCommonResources.CannotBeNullOrEmpty, nameof(message));
             }
 
             if (this.TreatTestAdapterErrorsAsWarnings

src/Microsoft.TestPlatform.Common/RunSettings.cs

@@ -69,7 +69,7 @@ public ISettingsProvider GetSettings(string settingsName)
         {
             if (StringUtilities.IsNullOrWhiteSpace(settingsName))
             {
-                throw new ArgumentException(ObjectModelCommonResources.CannotBeNullOrEmpty, "settingsName");
+                throw new ArgumentException(ObjectModelCommonResources.CannotBeNullOrEmpty, nameof(settingsName));
             }
 
             // Try and lookup the settings provider.

src/Microsoft.TestPlatform.Common/SettingsProvider/SettingsProviderExtensionManager.cs

@@ -181,7 +181,7 @@ internal LazyExtension<ISettingsProvider, ISettingsProviderCapabilities> GetSett
         {
             if (string.IsNullOrWhiteSpace(settingsName))
             {
-                throw new ArgumentException(ObjectModelCommonResources.CannotBeNullOrEmpty, "settingsName");
+                throw new ArgumentException(ObjectModelCommonResources.CannotBeNullOrEmpty, nameof(settingsName));
             }
 
             this.SettingsProvidersMap.TryGetValue(settingsName, out LazyExtension<ISettingsProvider, ISettingsProviderCapabilities> settingsProvider);

src/Microsoft.TestPlatform.CommunicationUtilities/LengthPrefixCommunicationChannel.cs

@@ -81,6 +81,7 @@ public void Dispose()
             EqtTrace.Verbose("LengthPrefixCommunicationChannel.Dispose: Dispose reader and writer.");
             this.reader.Dispose();
             this.writer.Dispose();
+            GC.SuppressFinalize(this);
         }
     }
 }