Register the TestProperty on deserialization. (#56)

Author: codito

src/Microsoft.TestPlatform.ObjectModel/TestObject.cs

@@ -43,6 +43,15 @@ private List<KeyValuePair<TestProperty, object>> StoreKeyValuePairs
                 // Store each property and value in the property data store.
                 foreach (var property in value)
                 {
+                    TestProperty.Register(
+                        property.Key.Id,
+                        property.Key.Label,
+                        property.Key.Category,
+                        property.Key.Description,
+                        property.Key.GetValueType(),
+                        null,
+                        property.Key.Attributes,
+                        typeof(TestObject));
                     this.SetPropertyValue(property.Key, property.Value, CultureInfo.InvariantCulture);
                 }
             }

test/Microsoft.TestPlatform.CommunicationUtilities.UnitTests/Serialization/TestObjectConverterTests.cs

@@ -79,7 +79,7 @@ public void TestObjectShouldSerializeDateTimeOffsetForProperty()
         [TestMethod]
         public void TestObjectShouldDeserializeCustomProperties()
         {
-            var json = "{\"Properties\":[{\"Key\":{\"Id\":\"1\",\"Label\":\"label1\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.Guid\"},\"Value\":\"02048dfd-3da7-475d-a011-8dd1121855ec\"},{\"Key\":{\"Id\":\"2\",\"Label\":\"label2\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.Int32\"},\"Value\":29}]}";
+            var json = "{\"Properties\":[{\"Key\":{\"Id\":\"13\",\"Label\":\"label1\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.Guid\"},\"Value\":\"02048dfd-3da7-475d-a011-8dd1121855ec\"},{\"Key\":{\"Id\":\"2\",\"Label\":\"label2\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.Int32\"},\"Value\":29}]}";
 
             var test = Deserialize<TestableTestObject>(json);
 
@@ -92,7 +92,7 @@ public void TestObjectShouldDeserializeCustomProperties()
         [TestMethod]
         public void TestObjectShouldDeserializeNullValueForProperty()
         {
-            var json = "{\"Properties\":[{\"Key\":{\"Id\":\"1\",\"Label\":\"label1\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":null}]}";
+            var json = "{\"Properties\":[{\"Key\":{\"Id\":\"14\",\"Label\":\"label1\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":null}]}";
 
             var test = Deserialize<TestableTestObject>(json);
 
@@ -104,7 +104,7 @@ public void TestObjectShouldDeserializeNullValueForProperty()
         [TestMethod]
         public void TestObjectShouldDeserializeStringArrayValueForProperty()
         {
-            var json = "{\"Properties\":[{\"Key\":{\"Id\":\"1\",\"Label\":\"label1\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String[]\"},\"Value\":[\"val1\", \"val2\"]}]}";
+            var json = "{\"Properties\":[{\"Key\":{\"Id\":\"15\",\"Label\":\"label1\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.String[]\"},\"Value\":[\"val1\", \"val2\"]}]}";
 
             var test = Deserialize<TestableTestObject>(json);
 
@@ -116,7 +116,7 @@ public void TestObjectShouldDeserializeStringArrayValueForProperty()
         [TestMethod]
         public void TestObjectShouldDeserializeDatetimeOffset()
         {
-            var json = "{\"Properties\":[{\"Key\":{\"Id\":\"11\",\"Label\":\"label1\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.DateTimeOffset\"},\"Value\":\"9999-12-31T23:59:59.9999999+00:00\"}]}";
+            var json = "{\"Properties\":[{\"Key\":{\"Id\":\"16\",\"Label\":\"label1\",\"Category\":\"\",\"Description\":\"\",\"Attributes\":0,\"ValueType\":\"System.DateTimeOffset\"},\"Value\":\"9999-12-31T23:59:59.9999999+00:00\"}]}";
 
             var test = Deserialize<TestableTestObject>(json);
 
@@ -125,6 +125,24 @@ public void TestObjectShouldDeserializeDatetimeOffset()
             Assert.AreEqual(DateTimeOffset.MaxValue, test.GetPropertyValue(properties[0]));
         }
 
+        [TestMethod]
+        public void TestObjectShouldAddPropertyToTestPropertyStoreOnDeserialize()
+        {
+            var json = "{\"Properties\":[{\"Key\":{\"Id\":\"17\",\"Label\":\"label1\",\"Category\":\"c\",\"Description\":\"d\",\"Attributes\":0,\"ValueType\":\"System.String\"},\"Value\":\"DummyValue\"}]}";
+
+            var test = Deserialize<TestableTestObject>(json);
+
+            var property = TestProperty.Find("17");
+            Assert.IsNotNull(property);
+            Assert.AreEqual("17", property.Id);
+            Assert.AreEqual("label1", property.Label);
+            Assert.AreEqual("c", property.Category);
+            Assert.AreEqual("d", property.Description);
+            Assert.AreEqual(typeof(string), property.GetValueType());
+            Assert.AreEqual(TestPropertyAttributes.None, property.Attributes);
+            Assert.AreEqual("DummyValue", test.GetPropertyValue(property));
+        }
+
         private static string Serialize<T>(T data)
         {
             return JsonDataSerializer.Instance.Serialize(data);