Skip to content

Commit 4ef707f

Browse files
authored
Add separate string for successful configuration units (#5002)
<!-- To check a checkbox place an "x" between the brackets. e.g: [x] --> - [x] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs). - [x] This pull request is related to an issue. - Resolves #4382 This PR adds a new string for configuration units to give additional clarity between the configuration set being applied successfully and each individual configuration unit being applied successfully ![image](https://github.com/user-attachments/assets/e6d09e22-e5f6-404c-9cc2-21bf90379df3) ----- ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5002)
1 parent 1deb4a8 commit 4ef707f

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

src/AppInstallerCLICore/Resources.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ namespace AppInstaller::CLI::Resource
106106
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationSettings);
107107
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationStatusWatchArgumentDescription);
108108
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationSuccessfullyApplied);
109+
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationUnitSuccessfullyApplied);
109110
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationSuppressPrologueArgumentDescription);
110111
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationUnexpectedTestResult);
111112
WINGET_DEFINE_RESOURCE_STRINGID(ConfigurationUnitAssertHadNegativeResult);

src/AppInstallerCLICore/Workflows/ConfigurationFlow.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -790,7 +790,7 @@ namespace AppInstaller::CLI::Workflow
790790
EndProgress();
791791
if (SUCCEEDED(resultInformation.ResultCode()))
792792
{
793-
m_context.Reporter.Info() << " "_liv << Resource::String::ConfigurationSuccessfullyApplied << std::endl;
793+
m_context.Reporter.Info() << " "_liv << Resource::String::ConfigurationUnitSuccessfullyApplied << std::endl;
794794
}
795795
else
796796
{

src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1811,6 +1811,9 @@ Please specify one of them using the --source option to proceed.</value>
18111811
</data>
18121812
<data name="ConfigurationSuccessfullyApplied" xml:space="preserve">
18131813
<value>Configuration successfully applied.</value>
1814+
</data>
1815+
<data name="ConfigurationUnitSuccessfullyApplied" xml:space="preserve">
1816+
<value>Unit successfully applied.</value>
18141817
</data>
18151818
<data name="ConfigurationWaitingOnAnother" xml:space="preserve">
18161819
<value>Another configuration is being applied to the system. This configuration will continue as soon as is possible...</value>

0 commit comments

Comments
 (0)