Skip to content

Commit e0c43c4

Browse files
authored
Add tests for ensuring integers are parsed correctly with leading zeroes (#5013)
<!-- To check a checkbox place an "x" between the brackets. e.g: [x] --> - [x] I have signed the [Contributor License Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs). - [ ] This pull request is related to an issue. I wasn't sure offhand if these versions would parse to be equal. I went to look at the test cases and found there were no tests that ensured that leading zeroes were parsed correctly. This PR adds the tests for clarity ----- ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5013)
1 parent f97417f commit e0c43c4

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

src/AppInstallerCLITests/Versions.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,16 @@ TEST_CASE("VersionCompare", "[versions]")
170170

171171
RequireEqual("1.0", "1.0.0");
172172

173+
// Ensure that integers are parsed correctly when there is a leading zero
174+
RequireEqual("1.2.00.3", "1.2.0.3");
175+
RequireEqual("1.2.003.4", "1.2.3.4");
176+
RequireEqual("01.02.03.04", "1.2.3.4");
177+
RequireEqual("1.2.03-beta", "1.2.3-beta");
178+
173179
// Ensure whitespace doesn't affect equality
174180
RequireEqual("1.0", "1.0 ");
175181
RequireEqual("1.0", "1. 0");
182+
RequireEqual("1.0", "1.0.");
176183

177184
// Ensure versions with preambles are sorted correctly
178185
RequireEqual("1.0", "Version 1.0");

0 commit comments

Comments
 (0)