Refactor: Enhancement of testing tools and code style.

- (Both tools): Avoid using the ternary operator
  - Refactor all ternary operator expressions with "if-else" snippet.
- (Tools/SandboxTest.ps1): Increase memory usage of Sandbox instance
  - Modifies the memory allocation for the Sandbox instance.
  - Increase to 1/4 of the total memory size.
  - This is useful for testing purposes, override default "2GB".
- (Tools/YamlCreate.ps1): Change log level
  - Change `$InformationPreference` to "Continue"
    - This will NOT suppress `Write-Information`

Signed-off-by: Dragon1573 <[email protected]>

Author: Dragon1573

Tools/SandboxTest.ps1

@@ -93,6 +93,12 @@ $script:SandboxWorkingDirectory = Join-Path -Path $script:SandboxDesktopFolder -
 $script:SandboxTestDataFolder = Join-Path -Path $script:SandboxDesktopFolder -ChildPath $($script:TestDataFolder | Split-Path -Leaf)
 $script:SandboxBootstrapFile = Join-Path -Path $script:SandboxTestDataFolder -ChildPath "$script:ScriptName.ps1"
 $script:HostGeoID = (Get-WinHomeLocation).GeoID
+# Use quater of the physical memory size for the sandbox, for increasing performance.
+$script:PrefferMemorySize = ((Get-WmiObject Win32_PhysicalMemory).Capacity | Measure-Object Capacity -Sum).Sum / (1MB) / 4
+if ($script:PrefferMemorySize -le 2048) {
+    # Physical memory is TOO small! Set the minimum to 2GB.
+    $script:PrefferMemorySize = 2048 # Minimum of 2GB
+}
 
 # Misc
 [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
@@ -230,14 +236,13 @@ function Get-RemoteContent {
     )
     Write-Debug "Attempting to fetch content from $URL"
     # Check if the URL is valid before trying to download
-    # If the URL is null, return a status code of 400
+    # Check if URL is empty
     if ([String]::IsNullOrWhiteSpace($URL)) {
         $response = @{ StatusCode = 400 }
     } else {
         # Try to fetch headers from the URL
         $response = Invoke-WebRequest -Proxy $Proxy -Uri $URL -Method Head -ErrorAction SilentlyContinue
     }
-
     if ($response.StatusCode -ne 200) {
         Write-Debug "Fetching remote content from $URL returned status code $($response.StatusCode)"
         return $null
@@ -255,7 +260,6 @@ function Get-RemoteContent {
     } else {
         $script:CleanupPaths += @()
     }
-
     try {
         $downloadTask = $script:HttpClient.GetByteArrayAsync($URL)
         [System.IO.File]::WriteAllBytes($localfile.FullName, $downloadTask.Result)
@@ -867,8 +871,9 @@ Write-Verbose 'Creating WSB file for launching the sandbox'
     </MappedFolder>
   </MappedFolders>
   <LogonCommand>
-  <Command>PowerShell Start-Process PowerShell -WindowStyle Maximized -WorkingDirectory '$($script:SandboxWorkingDirectory)' -ArgumentList '-ExecutionPolicy Bypass -NoExit -NoLogo -File $($script:SandboxBootstrapFile)'</Command>
+    <Command>PowerShell Start-Process PowerShell -WindowStyle Maximized -WorkingDirectory '$($script:SandboxWorkingDirectory)' -ArgumentList '-ExecutionPolicy Bypass -NoExit -NoLogo -File $($script:SandboxBootstrapFile)'</Command>
   </LogonCommand>
+  <memoryInMB>$script:PrefferMemorySize</memoryInMB>
 </Configuration>
 "@ | Out-File -FilePath $script:ConfigurationFile
 

Tools/YamlCreate.ps1

@@ -44,6 +44,7 @@ Param
   [string] $Proxy = $null
 )
 $ProgressPreference = 'SilentlyContinue'
+$InformationPreference = 'Continue'
 
 if (!$Proxy) {
   # Try inspect the system-level proxy settings by visiting GitHub RESTful API Endpoint and extract proxy settings from it.